Re: Re: JaroWinkler extension

Hi, sorry for the delay, but i'm rewriting the code from scratch in my free time because i would like to publish it with bsd license. Best Regards, Daniele Il 11/11/2010 18.06, Johannes Schlüter ha scritto:

On Thu, 2010-11-11 at 15:48 +0100, Daniele Salvatore Albano wrote:

I got the implementation from here because MAX_VAR_SIZE limitation was dropped. http://cpansearch.perl.org/src/SCW/Text-JaroWinkler-0.1/strcmp95.c

Richard already comment on some other parts, I didn't review the code, but one note about this: That file is licensed "under the same terms as Perl itself" which means either GPL or Artistic License. PHP License and GPL are incompatible so we have to look at the Artistic License[1] which is, from a legal perspective, quite imprecise which makes it hard to apply. Especially it is not clear about taking just parts of the "package". I assume taking parts of it is a "modification" by reducing it. Given that I assume that pecl.php.net is a "major archive site" so section 3.a of the licensed would be full-filled and it would be ok to take the code. But I still wanted to raise this issue, in case somebody disagrees. johannes [1] http://www.perlfoundation.org/artistic_license_1_0