Re: cvs: pecl /apc apc_compile.c apc_globals.h php_apc.c

From:	Gopal Vijayaraghavan	Date:	Tue, 17 Oct 2006 08:18:33 +0000
Subject:	Re: cvs: pecl /apc apc_compile.c apc_globals.h php_apc.c
References:	1	Groups:	php.apc.dev
Request:	Send a blank email to php-apc-dev+get-14@lists.php.net to get a copy of this message

Brian Shire wrote:

+    /* Maintain a list of zvals we've copied to properly handle recursive structures */
+    if(!APCG(copied_zvals)) {
+        APCG(copied_zvals) = emalloc(sizeof(HashTable));
+        zend_hash_init(APCG(copied_zvals), 0, NULL, NULL, 0);

Are you sure this is the best way ? That bug was left hanging because I didn't want to do this and penalize those who don't use apc_store/fetch with an extra memory penalty for every request. If you don't mind, I'll be rewriting this bit sometime next week or so. Cheers, Gopal -- If I learn from my mistakes, pretty soon I'll know everything.