Re: Results
| From: | Shane Caraveo | Date: | Mon, 05 Oct 1998 13:39:02 +0000 |
| Subject: | Re: Results | ||
| References: | 1 2 3 | Groups: | php.beta |
| Request: | Send a blank email to php-beta+get-47@lists.php.net to get a copy of this message | ||
Zeev Suraski wrote:
>
> At 15:17 04/10/98 -0400, Shane Caraveo wrote:
> >
> >> I guess you're using a recent MysQL 3.22 version. Monty changed a function
> >> to return unsigned long instead of unsigned int. Until 3.22 becomes more
> >> popular than 3.21 and 3.20, we'll stay with the old definition... It's
> >> harmless.
> >>
> >> Zeev
> >
> >
> >Hmm, why? It's easy enough to do defines against that (I already did
>
> Because I don't like so many multiple cases using #define's. Monty did
> that specifically because there's no problem with downwards compatability,
> I'd prefer keeping it that way...
>
> Zeev
Granted, what you did might be a bit better, but I personaly just don't
buy adding a couple defines as a reason to not make those changes. It's
not like all the code had to be rewriten to get rid of a few warnings.
And I'm sorry, but 3.0 is littered with defines. It's just one of the
(many) reasons I did sapi in 3.1, which removed a lot of the defines in
the core of 3.0.
Shane