#35673 [Sus->Csd]: formatOutput does not work with saveHTML

ID: 35673 Updated by: rrichards@php.net Reported By: ken at smallboxsoftware dot net -Status: Suspended +Status: Closed Bug Type: DOM XML related Operating System: Linux PHP Version: 6CVS, 5CVS Assigned To: rrichards New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. implemented in HEAD when using libxml2-2.6.23+ Previous Comments: ------------------------------------------------------------------------ [2005-12-15 12:20:40] rrichards@php.net not without re-creating the code for encoding and handling the output buffer and the function would then call htmlDocContentDumpFormatOutput. Not worth this just to disable the formatting for a string (right now it always formats output for saveHTML). i will just add the appropriate functionality in libxml2. if you really need it disabled you can always write a custom stream handler that concats the output to a string and use it with saveHTMLFile. ------------------------------------------------------------------------ [2005-12-15 07:26:13] ken at smallboxsoftware dot net Would libxml function htmlNodeDumpFormatOutput not suffice in this case? ------------------------------------------------------------------------ [2005-12-15 01:02:27] rrichards@php.net Will fix once suitable api exists in libxml2 for this. currently only works when saving to file without duplicating all the routines needed. ------------------------------------------------------------------------ [2005-12-14 23:16:21] ken at smallboxsoftware dot net Description: ------------ saveHTML does not appear to format output. I assume it is supposed to because the manual entry for this function shows ->formatOutput = true From the C code for the function: DOM_GET_OBJ(docp, id, xmlDocPtr, intern); htmlDocDumpMemory(docp, &mem, &size); as opposed for the C function for saveHTMLFile which does appear to format output: DOM_GET_OBJ(docp, id, xmlDocPtr, intern); /* encoding handled by property on doc */ doc_props = dom_get_doc_props(intern->document); format = doc_props->formatoutput; bytes = htmlSaveFileFormat(file, docp, NULL, format); ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=35673&edit=1