#40213 [Opn->Fbk]: easter_date() returns wrong timestamp if ...

ID: 40213 Updated by: tony2001@php.net Reported By: oliver dot block at lycos dot de -Status: Open +Status: Feedback Bug Type: Calendar related Operating System: Linux PHP Version: 5.2.1RC3 New Comment: Naaah, calling mktime() with call_user_function() is just a hack, not a solution. I've said we probably need to rewrite it from scratch and merge it into ext/date to use ext/date _internal_ functions directly, not through the user API. Previous Comments: ------------------------------------------------------------------------ [2007-01-29 22:03:11] oliver dot block at lycos dot de I modified some of the testfiles from the former archives, because of wrong test results. It happens that easter date and DST shift occur on the same day. If so, date('Y-m-d H:i:s', easter_date($year)) will return a time portion of 01:00:00 and not 00:00:00 You find the archive here: http://www.block-online.eu/phptests/tests_easter_date.tar.gz ------------------------------------------------------------------------ [2007-01-25 21:04:02] oliver dot block at lycos dot de You will find the diff file here now: http://mitglied.lycos.de/oblock/php/easter.c.diff.gz ------------------------------------------------------------------------ [2007-01-25 20:20:22] bjori@php.net 404 not found.. ------------------------------------------------------------------------ [2007-01-25 20:16:28] oliver dot block at lycos dot de Let's start with the first function.:) You will find a diff file here: http://mitglied.lycos.de/oblock/easter.c.diff I also created more test files http://mitglied.lycos.de/oblock/easter_date_test.tar.gz Please check everthing and decide if you want to include it. ------------------------------------------------------------------------ [2007-01-24 13:54:13] tony2001@php.net Basically we need to rewrite ext/calendar from scratch (to use ext/date types and utilities) and probably merge it into ext/date. Volunteers are welcome. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/40213 -- Edit this bug report at http://bugs.php.net/?id=40213&edit=1