#40776 [Asn]: highlight.bg setting ignored/unused

ID: 40776 User updated by: seanius at debian dot org Reported By: seanius at debian dot org Status: Assigned Bug Type: PHP options/info functions Operating System: Debian GNU/Linux PHP Version: 5.2.1 Assigned To: tony2001 New Comment: okay, since i'm just kind of acting as an inefficient middle-man here i'll ask the reporter to comment directly to the bug here :) Previous Comments: ------------------------------------------------------------------------ [2007-04-07 11:49:04] johannes@php.net The patch should be changed to not using the HTML body tag for the background color since highlight_file() might be used to embed highlighted code into another file. I also see no need to use highlight_bg as last_color. ------------------------------------------------------------------------ [2007-04-06 23:15:40] seanius at debian dot org hi, just fyi: a patch has been supplied by the reporter in the debian bts: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405338;msg=34;filename=118-highlight_bg.patch;att=1 sorry the urls for attachments suck, you can also browse to it at the address originally provided :) ------------------------------------------------------------------------ [2007-03-11 13:45:58] seanius at debian dot org Description: ------------ originally reported at http://bugs.debian.org/405338 it seems that the highlight.bg setting is being ignored for highlight_string/highlight_file(). or perhaps this setting is obsoleted/removed intentionally? the online docs and php-provided ini files still reference this setting though, and it shows up correctly in phpinfo(). grepping through the source for php5 however, i don't find much referencing the setting apart from the ini file and some test cases. the highlight_file function in ext/standard/base_functions.c sets the other settings from the "higlight struct", but not the .bg setting. Reproduce code: --------------- <?php # set highlight.bg to something obvious like #ff0000 # and you'll see that the background stays default. # Comment highlight_file($_SERVER['SCRIPT_FILENAME']); ?> Expected result: ---------------- a red background Actual result: -------------- a white default background ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=40776&edit=1