#41609 [Opn]: file_put_contents() injects \r

ID: 41609 Updated by: pajoye@php.net Reported By: zoe at uk dot ibm dot com Status: Open Bug Type: Filesystem function related Operating System: Windows XP PHP Version: 6CVS-2007-06-06 (snap) New Comment: "I don't see that as magical.. If a binary string is given, you want it writen as-is, IMHO. I'm classifying back to a PHP bug, because I feel this needs more discussion." Yes, but it is still magic as it introduces possible confusions and wtf factors. Having to specify the mode just like you do with fopen is clear and not confusing. It is only in Unicode mode so no BC involved either. Previous Comments: ------------------------------------------------------------------------ [2007-06-11 17:47:11] nlopess@php.net "I'm pretty sure that FILE_BINARY solves your issue. It may use it automatically when a binary string is given, but I would find that trickier (magic++)" I don't see that as magical.. If a binary string is given, you want it writen as-is, IMHO. I'm classifying back to a PHP bug, because I feel this needs more discussion. ------------------------------------------------------------------------ [2007-06-11 12:15:56] pajoye@php.net "*IF* there is some work needed on the docs is the right process to open another defect?" Good point, there is a lot of work to be done regarding php6 behaviors of each function. I'm not sure what the phpdoc team decided but I will let them comment here, if required. changed to open + documentation problem. ------------------------------------------------------------------------ [2007-06-11 11:30:25] zoe at uk dot ibm dot com Fair enough - I was wondering if it should also be either RTFM or WTFM? Just had a quick look at what I hope are the PHP6 docs and I can't see the new put_file_contents() flags documented yet. *IF* there is some work needed on the docs is the right process to open another defect? ------------------------------------------------------------------------ [2007-06-11 10:58:07] pajoye@php.net Not a bug > bogus (I don't like this word but well :) ------------------------------------------------------------------------ [2007-06-11 09:56:24] zoe at uk dot ibm dot com Yes - you are right. The FILE_BINARY flag does fix the problem. I'm closing this. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/41609 -- Edit this bug report at http://bugs.php.net/?id=41609&edit=1