#42627 [NEW]: bz2 extension fails to build with -fno-common

From: jdolecek at netbsd dot org Operating system: Mac OS X PHP version: 5.2.4 PHP Bug Type: Compile Failure Bug description: bz2 extension fails to build with -fno-common Description: ------------ bz2 extension header causes php_bz2_filter_factory symbol to be a common symbol, rather then extern variable, due to lacking 'extern' modifier. When compiling on Mac OS X, which uses -fno-common by default, this causes build failure. The header should define it just as extern, since the symbol is properly declared in bz2_filter.c. Fix: --- ext/bz2/php_bz2.h.orig 2007-09-02 20:11:08.000000000 +0200 +++ ext/bz2/php_bz2.h @@ -51,7 +51,7 @@ PHP_BZ2_API php_stream *_php_stream_bz2o #define php_stream_bz2open_from_BZFILE(bz, mode, innerstream) _php_stream_bz2open_from_BZFILE((bz), (mode), (innerstream) STREAMS_CC TSRMLS_CC) #define php_stream_bz2open(wrapper, path, mode, options, opened_path) _php_stream_bz2open((wrapper), (path), (mode), (options), (opened_path), NULL STREAMS_CC TSRMLS_CC) -php_stream_filter_factory php_bz2_filter_factory; +extern php_stream_filter_factory php_bz2_filter_factory; extern php_stream_ops php_stream_bz2io_ops; #define PHP_STREAM_IS_BZIP2 &php_stream_bz2io_ops -- Edit bug report at http://bugs.php.net/?id=42627&edit=1 -- Try a CVS snapshot (PHP 4.4): http://bugs.php.net/fix.php?id=42627&r=trysnapshot44 Try a CVS snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=42627&r=trysnapshot52 Try a CVS snapshot (PHP 6.0): http://bugs.php.net/fix.php?id=42627&r=trysnapshot60 Fixed in CVS: http://bugs.php.net/fix.php?id=42627&r=fixedcvs Fixed in release: http://bugs.php.net/fix.php?id=42627&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=42627&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=42627&r=needscript Try newer version: http://bugs.php.net/fix.php?id=42627&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=42627&r=support Expected behavior: http://bugs.php.net/fix.php?id=42627&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=42627&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=42627&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=42627&r=globals PHP 3 support discontinued: http://bugs.php.net/fix.php?id=42627&r=php3 Daylight Savings: http://bugs.php.net/fix.php?id=42627&r=dst IIS Stability: http://bugs.php.net/fix.php?id=42627&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=42627&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=42627&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=42627&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=42627&r=mysqlcfg