#43385 [Fbk->Opn]: browser_reg_compare frees stack variable
| From: | andy at petdance dot com | Date: | Mon, 26 Nov 2007 13:54:03 +0000 |
| Subject: | #43385 [Fbk->Opn]: browser_reg_compare frees stack variable | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-120089@lists.php.net to get a copy of this message | ||
ID: 43385
User updated by: andy at petdance dot com
Reported By: andy at petdance dot com
-Status: Feedback
+Status: Open
Bug Type: *General Issues
Operating System: *
PHP Version: 5.3CVS-2007-11-23 (CVS)
New Comment:
Because you never call free() on something that has not been
malloc()ed.
Previous Comments:
------------------------------------------------------------------------
[2007-11-26 10:49:26] jani@php.net
You mean regfree() is not appropriate? How come?
------------------------------------------------------------------------
[2007-11-23 06:47:33] andy at petdance dot com
Then again, it seems to be happening all over, not just in this one
function. It sure seems to be a segfault waiting to happen.
------------------------------------------------------------------------
[2007-11-23 06:31:44] andy at petdance dot com
Description:
------------
At the tail end of browser_reg_compare, it frees stack variable r.
This is never appropriate.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=43385&edit=1