#43696 [Opn->Csd]: op2 of OP_DATA which after INIT_NS_FCALL_BY_NAME is uninitialized

ID: 43696 Updated by: felipe@php.net Reported By: phpxcache at gmail dot com -Status: Open +Status: Closed Bug Type: Scripting Engine problem Operating System: linux PHP Version: 5.3CVS-2007-12-28 (CVS) New Comment: This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2007-12-28 09:07:58] phpxcache at gmail dot com Description: ------------ as you can see in zend_compile.c opline->opcode = ZEND_INIT_NS_FCALL_BY_NAME; ZEND_INIT_NS_FCALL_BY_NAME's op1 is initialized, so is op2 ......... opline->opcode = ZEND_OP_DATA; ZEND_OP_DATA's op1 is initialized here but op2 is not it may not cause problem in zend executor but may in opcode optimizers/cachers suggested fix: Index: zend_compile.c =================================================================== RCS file: /repository/ZendEngine2/zend_compile.c,v retrieving revision 1.647.2.27.2.41.2.32 diff -u -r1.647.2.27.2.41.2.32 zend_compile.c --- zend_compile.c 27 Dec 2007 13:52:05 -0000 1.647.2.27.2.41.2.32 +++ zend_compile.c 28 Dec 2007 08:56:41 -0000 @@ -1504,6 +1504,7 @@ Z_TYPE(opline->op1.u.constant) = IS_STRING; Z_STRLEN(opline->op1.u.constant) = Z_STRLEN(function_name->u.constant) - prefix_len; Z_STRVAL(opline->op1.u.constant) = zend_str_tolower_dup(Z_STRVAL(function_name->u.constant) + prefix_len, Z_STRLEN(opline->op1.u.constant)); + SET_UNUSED(opline->op2); opline->extended_value = zend_hash_func(Z_STRVAL(opline->op1.u.constant), Z_STRLEN(opline->op1.u.constant) + 1); } else { opline->opcode = ZEND_INIT_FCALL_BY_NAME; ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=43696&edit=1