#44018 [Fbk->Opn]: RecursiveDirectoryIterator options inconsistancy
| From: | jordan dot raub at dataxltd dot com | Date: | Mon, 04 Feb 2008 18:11:04 +0000 |
| Subject: | #44018 [Fbk->Opn]: RecursiveDirectoryIterator options inconsistancy | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-121958@lists.php.net to get a copy of this message | ||
ID: 44018
User updated by: jordan dot raub at dataxltd dot com
Reported By: jordan dot raub at dataxltd dot com
-Status: Feedback
+Status: Open
Bug Type: SPL related
Operating System: *
PHP Version: 5.2.5
Assigned To: helly
New Comment:
looking through the code it looks like DIT_CTOR_FLAGS shouldn't be sent
for the RecursiveDirectoryIterator. Maybe another flag should be sent
(RDIT_CTOR_FLAGS = 0x00000010) and the flags sent to the
parse_parameters should be default SPL_FILE_DIR_CURRENT_AS_SELF to
denote that "this" should be a RecursiveDirectoryIterator?
$options not passed
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
$options = 0
string(21) "/virtualhosts/tmp/dir"
object(RecursiveDirectoryIterator)#2 (4) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#2 (4) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
$options = 10
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#2 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
$options = 100
string(3) "dir"
object(RecursiveDirectoryIterator)#4 (3) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#4 (3) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
$options = 110
string(3) "dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
Previous Comments:
------------------------------------------------------------------------
[2008-02-04 17:21:07] helly@php.net
Please try using this CVS snapshot:
http://snaps.php.net/php5.3-latest.tar.gz
For Windows (zip):
http://snaps.php.net/win32/php5.3-win32-latest.zip
For Windows (installer):
http://snaps.php.net/win32/php5.3-win32-installer-latest.msi
There is indeed an issue. Can you update from cvs (5.3 or HEAD) and
try
again please?
------------------------------------------------------------------------
[2008-02-04 16:22:56] jordan dot raub at dataxltd dot com
similar result with the latest snapshot...
$options not passed
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
$options = 0
string(21) "/virtualhosts/tmp/dir"
object(RecursiveDirectoryIterator)#2 (4) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#2 (4) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
$options = 10
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#2 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
$options = 100
string(3) "dir"
object(RecursiveDirectoryIterator)#4 (3) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#4 (3) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["glob":"DirectoryIterator":private]=>
bool(false)
["subPathName":"RecursiveDirectoryIterator":private]=>
string(0) ""
}
$options = 110
string(3) "dir"
object(SplFileInfo)#3 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(21) "/virtualhosts/tmp/dir"
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (2) {
["pathName":"SplFileInfo":private]=>
string(17) "/virtualhosts/tmp"
["fileName":"SplFileInfo":private]=>
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
}
------------------------------------------------------------------------
[2008-02-04 14:39:06] helly@php.net
Please try using this CVS snapshot:
http://snaps.php.net/php5.3-latest.tar.gz
For Windows (zip):
http://snaps.php.net/win32/php5.3-win32-latest.zip
For Windows (installer):
http://snaps.php.net/win32/php5.3-win32-installer-latest.msi
------------------------------------------------------------------------
[2008-02-01 22:02:28] jordan dot raub at dataxltd dot com
(oops sorry... first paragraph should have been....)
creating a new RecursiveDirectoryIterator with no options passed and 0
as the options passed give 2 different things. for nothing passed the
current value is an SplFileInfo while for a 0 passed a
RecursiveDirectoryIterator object is passed. I would think that sending
in 0 and nothing would give the same thing. Also in
RecursiveDirectoryIterator constructor (ext/spl/spl_directory.c line 965
php5.2.5 not CVS) the flags are automatically set to return an
SplFileInfo object, should this not be a RecursiveDirectoryIterator?
(correct me if i'm wrong)
------------------------------------------------------------------------
[2008-02-01 21:56:38] jordan dot raub at dataxltd dot com
Description:
------------
creating a new RecursiveDirectoryIterator with no options passes and 0
as the options passed give 2 different things. for nothing passed the
current value is a RecursiveDirectoryIterator while for a 0 passed a
SplFileInfo object is passed. I would think that sending in 0 and
nothing would give the same thing. Also in RecursiveDirectoryIterator
constructor (ext/spl/spl_directory.c line 965 php5.2.5 not CVS) the
flags are automatically set to return an SplFileInfo object, should this
not be a RecursiveDirectoryIterator? (correct me if i'm wrong)
also the documentation has the constants set:
const CURRENT_AS_FILEINFO RecursiveDirectoryIterator::x00000010
const KEY_AS_FILENAME RecursiveDirectoryIterator::x00000020
while from this test code they should be the following
const CURRENT_AS_FILEINFO RecursiveDirectoryIterator::x00000010
const KEY_AS_FILENAME RecursiveDirectoryIterator::x00000100
Thanks,
Jordan
Reproduce code:
---------------
#!/usr/lib/php5/bin/php
<?php
printf("\$options not passed\n");
foreach(new RecursiveDirectoryIterator(dirname(__FILE__)) as $key =>
$file)
{
var_dump($key);
var_dump($file);
}
$options = 0;
printf("\$options = %x\n", $options);
foreach(new RecursiveDirectoryIterator(dirname(__FILE__), $options) as
$key => $file)
{
var_dump($key);
var_dump($file);
}
$options = 0;
$options |= RecursiveDirectoryIterator::CURRENT_AS_FILEINFO;
printf("\$options = %x\n", $options);
foreach(new RecursiveDirectoryIterator(dirname(__FILE__), $options) as
$key => $file)
{
var_dump($key);
var_dump($file);
}
$options = 0;
$options |= RecursiveDirectoryIterator::KEY_AS_FILENAME;
printf("\$options = %x\n", $options);
foreach(new RecursiveDirectoryIterator(dirname(__FILE__), $options) as
$key => $file)
{
var_dump($key);
var_dump($file);
}
$options = 0;
$options |= RecursiveDirectoryIterator::CURRENT_AS_FILEINFO;
$options |= RecursiveDirectoryIterator::KEY_AS_FILENAME;
printf("\$options = %x\n", $options);
foreach(new RecursiveDirectoryIterator(dirname(__FILE__), $options) as
$key => $file)
{
var_dump($key);
var_dump($file);
}
Expected result:
----------------
$options not passed
string(21) "/virtualhosts/tmp/dir"
object(RecursiveDirectoryIterator)#2 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#2 (0) {
}
$options = 0
string(21) "/virtualhosts/tmp/dir"
object(RecursiveDirectoryIterator)#2 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#2 (0) {
}
$options = 10
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#2 (0) {
}
$options = 100
string(3) "dir"
object(RecursiveDirectoryIterator)#4 (0) {
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#4 (0) {
}
$options = 110
string(3) "dir"
object(SplFileInfo)#3 (0) {
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (0) {
}
Actual result:
--------------
$options not passed
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (0) {
}
$options = 0
string(21) "/virtualhosts/tmp/dir"
object(RecursiveDirectoryIterator)#2 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#2 (0) {
}
$options = 10
string(21) "/virtualhosts/tmp/dir"
object(SplFileInfo)#3 (0) {
}
string(52) "/virtualhosts/tmp/RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#2 (0) {
}
$options = 100
string(3) "dir"
object(RecursiveDirectoryIterator)#4 (0) {
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(RecursiveDirectoryIterator)#4 (0) {
}
$options = 110
string(3) "dir"
object(SplFileInfo)#3 (0) {
}
string(34) "RecursiveDirectoryIteratorTest.php"
object(SplFileInfo)#4 (0) {
}
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=44018&edit=1