#44219 [Fbk->Csd]: Fix for Bug #44209 Causes Test Regression
ID: 44219
Updated by: derick@php.net
Reported By: kirkland at ubuntu dot com
-Status: Feedback
+Status: Closed
Bug Type: Date/time related
Operating System: Linux 64 bit
PHP Version: 5.2.5
New Comment:
This bug has been fixed in CVS.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2008-02-25 11:35:45] bisho at onirica dot com
It seens a test-problem, not a regression. The new output of
int(-62169962400) is correct.
------------------------------------------------------------------------
[2008-02-24 19:51:42] jani@php.net
Please try using this CVS snapshot:
http://snaps.php.net/php5.2-latest.tar.gz
For Windows (zip):
http://snaps.php.net/win32/php5.2-win32-latest.zip
For Windows (installer):
http://snaps.php.net/win32/php5.2-win32-installer-latest.msi
------------------------------------------------------------------------
[2008-02-22 20:31:34] kirkland at ubuntu dot com
Test script:
# cat /tmp/foo.php
<?php
var_dump(strtotime('0000-00-00 00:00:00'));
?>
Built without patch:
# php /tmp/foo.php
bool(false)
Built with patch:
# ./cli-build/sapi/cli/php /tmp/foo.php
int(-62169962400)
------------------------------------------------------------------------
[2008-02-22 20:21:41] kirkland at ubuntu dot com
In other words, adding that 3-line patch creates the following test
regressions. The following tests now fail on 64-bit Linux:
+ Bug #41523 (strtotime('0000-00-00 00:00:00') is parsed as 1999-11-30)
[ext/date/tests/bug41523.phpt]
+ mktime() [3] [ext/date/tests/mktime-3.phpt]
+ strtotime() and mysql timestamps
[ext/date/tests/strtotime-mysql.phpt]
+ strtotime() function [ext/date/tests/strtotime3.phpt]
+ wddx deserialization test [ext/wddx/tests/001.phpt]
------------------------------------------------------------------------
[2008-02-22 19:12:18] kirkland at ubuntu dot com
The diff shown in that pastebin is from two subsequent runs, both on
64-bit Linux.
The only difference between the two is:
+++ php-src/ext/date/lib/timelib.h Fri Feb 22 09:48:18 2008
...
+#if HAVE_LIMITS_H
+#include <limits.h>
+#endif
...
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/44219
--
Edit this bug report at http://bugs.php.net/?id=44219&edit=1
Thread (8 messages)