#44975 [Asn->Csd]: ext/date/php_date has comments starting with //
| From: | derick@php.net | Date: | Tue, 08 Jul 2008 18:03:11 +0000 |
| Subject: | #44975 [Asn->Csd]: ext/date/php_date has comments starting with // | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-126399@lists.php.net to get a copy of this message | ||
ID: 44975
Updated by: derick@php.net
Reported By: orchard at engr dot wisc dot edu
-Status: Assigned
+Status: Closed
Bug Type: Compile Failure
Operating System: Solaris 9
PHP Version: 5.2.6
Assigned To: derick
New Comment:
This bug has been fixed in CVS.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2008-05-12 20:42:43] derick@php.net
Already noticed it, but hadn't patched it.
------------------------------------------------------------------------
[2008-05-12 20:39:51] orchard at engr dot wisc dot edu
Description:
------------
ext/date/php_date.c has comments starting with // rather than enclosed
in /* and */ The Sun WS6 compiler does no accept such comments.
[tiger] 149% diff -c php_date.c.orig php_date.c
*** php_date.c.orig Wed Apr 16 12:21:46 2008
--- php_date.c Mon May 12 15:08:17 2008
***************
*** 269,277 ****
int initialized;
int type;
union {
! timelib_tzinfo *tz; // TIMELIB_ZONETYPE_ID;
! timelib_sll utc_offset; // TIMELIB_ZONETYPE_OFFSET
! struct // TIMELIB_ZONETYPE_ABBR
{
timelib_sll utc_offset;
char *abbr;
--- 269,277 ----
int initialized;
int type;
union {
! timelib_tzinfo *tz; /* TIMELIB_ZONETYPE_ID; */
! timelib_sll utc_offset; /* TIMELIB_ZONETYPE_OFFSET
*/
! struct /* TIMELIB_ZONETYPE_ABBR
*/
{
timelib_sll utc_offset;
char *abbr;
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=44975&edit=1