#46191 [Opn->Csd]: Back-comp break: DOMDocument::saveXML() doesn't accept null anymore

From: Date: Sun, 28 Sep 2008 12:04:08 +0000
Subject: #46191 [Opn->Csd]: Back-comp break: DOMDocument::saveXML() doesn't accept null anymore
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-129297@lists.php.net to get a copy of this message 
 ID:               46191
 Updated by:       rrichards@php.net
 Reported By:      zizka at seznam dot cz
-Status:           Open
+Status:           Closed
 Bug Type:         DOM XML related
 Operating System: Any
 PHP Version:      5.2.6
 New Comment:

This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2008-09-28 10:09:48] zizka at seznam dot cz

Description:
------------
In PHP 5.2.5, DOMDocument::saveXML() accepted null as it's first
argument, which has this documentation:

Use this parameter to output only a specific node without XML
declaration rather than the entire document. 

In PHP 5.2.6, passing null causes error.

Reproduce code:
---------------
// $doc is a DOM document object.
return $doc->saveXML(null, LIBXML_NOEMPTYTAG);

Expected result:
----------------
IMHO null is reasonable value, meaning that whole document should be
saved. I suggest to fix this backward compatibility break.

Actual result:
--------------
Catchable fatal error: Argument 1 passed to DOMDocument::saveXML() must
be an instance of DOMNode, null given, called in ...\index.php on line
97 and defined in ...\inc.Menu.php on line 23


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=46191&edit=1

Thread (2 messages)

« previous php.bugs (#129297) next »