#46040 [Csd]: [PATCH] pcre_internal.h parse error during compilation

From: Date: Mon, 29 Sep 2008 06:06:29 +0000
Subject: #46040 [Csd]: [PATCH] pcre_internal.h parse error during compilation
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-129316@lists.php.net to get a copy of this message 
 ID:               46040
 User updated by:  Bjorn dot Wiberg at its dot uu dot se
 Reported By:      Bjorn dot Wiberg at its dot uu dot se
 Status:           Closed
 Bug Type:         Compile Failure
 Operating System: IBM AIX 5.3 5300-08-01-0819
 PHP Version:      5.3CVS-2008-09-10 (snap)
 New Comment:

Hi again!

It seems that my patch has not (yet?) been included with
php5.3-200809290430. Will it be, or are you expecting the PCRE
developers to release a fix and include that with PHP 5.3 instead?
Should this bug really be closed until this has been resolved?

Thanks in advance!

Best regards,
Björn


Previous Comments:
------------------------------------------------------------------------

[2008-09-28 20:48:08] nlopess@php.net

forwarded upstream: http://bugs.exim.org/show_bug.cgi?id=761

------------------------------------------------------------------------

[2008-09-16 11:29:20] Bjorn dot Wiberg at its dot uu dot se

Will you report this upstream?
And apply the fix in the meantime?

Many thanks in advance!

Best regards,
Björn

------------------------------------------------------------------------

[2008-09-11 12:27:33] scottmac@php.net

This really needs to go upstream to
http://bugs.exim.org/enter_bug.cgi?product=PCRE

We can fix it as well though.

------------------------------------------------------------------------

[2008-09-11 11:39:10] Bjorn dot Wiberg at its dot uu dot se

Attaching patch below which solves the problem.


*** php5.3-200809100630/ext/pcre/pcrelib/pcre_internal.h.ORIGINAL      
2008-09-11 13:19:06.000000000 +0200
--- php5.3-200809100630-my/ext/pcre/pcrelib/pcre_internal.h    
2008-09-11 13:19:46.000000000 +0200
***************
*** 562,570 ****
  /* Miscellaneous definitions. The #ifndef is to pacify compiler
warnings in
  environments where these macros are defined elsewhere. */
  
! #ifndef FALSE
  typedef int BOOL;
  
  #define FALSE   0
  #define TRUE    1
  #endif
--- 562,572 ----
  /* Miscellaneous definitions. The #ifndef is to pacify compiler
warnings in
  environments where these macros are defined elsewhere. */
  
! #ifndef BOOL
  typedef int BOOL;
+ #endif
  
+ #ifndef FALSE
  #define FALSE   0
  #define TRUE    1
  #endif

------------------------------------------------------------------------

[2008-09-10 20:13:58] jani@php.net

"Perhaps" ?? Why don't you TRY it? And if it works -> send us a 
patch.

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/46040

-- 
Edit this bug report at http://bugs.php.net/?id=46040&edit=1

Thread (10 messages)

« previous php.bugs (#129316) next »