#47721 [Opn->Csd]: Aligment issues in mbstring and sysvshm extensions
| From: | iliaa@php.net | Date: | Thu, 19 Mar 2009 23:12:02 +0000 |
| Subject: | #47721 [Opn->Csd]: Aligment issues in mbstring and sysvshm extensions | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-134907@lists.php.net to get a copy of this message | ||
ID: 47721
Updated by: iliaa@php.net
Reported By: crrodriguez at opensuse dot org
-Status: Open
+Status: Closed
Bug Type: *General Issues
Operating System: Linux ia64
PHP Version: 5.2CVS-2009-03-19 (CVS)
New Comment:
This bug has been fixed in CVS.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2009-03-19 17:19:04] crrodriguez at opensuse dot org
Description:
------------
in platforms which strictly alignment is required, we still have some
bugs..
patch:
--- ext/mbstring/oniguruma/regint.h
+++ ext/mbstring/oniguruma/regint.h
@@ -256,7 +256,7 @@
#define NULL_UCHARP ((UChar* )0)
#ifndef PLATFORM_UNALIGNED_WORD_ACCESS
-#define WORD_ALIGNMENT_SIZE SIZEOF_INT
+#define WORD_ALIGNMENT_SIZE SIZEOF_LONG
#define GET_ALIGNMENT_PAD_SIZE(addr,pad_size) do {\
(pad_size) = WORD_ALIGNMENT_SIZE \
--- ext/sysvshm/sysvshm.c
+++ ext/sysvshm/sysvshm.c
@@ -375,7 +375,7 @@ static int php_put_shm_data(sysvshm_chun
long total_size;
long shm_varpos;
- total_size = ((long) (len + sizeof(sysvshm_chunk) - 1) / 4) * 4 +
4; /* 4-byte alligment */
+ total_size = ((long) (len + sizeof(sysvshm_chunk) - 1) /
sizeof(long)) * sizeof(long) + sizeof(long); /* long alligment */
if ((shm_varpos = php_check_shm_data(ptr, key)) > 0) {
php_remove_shm_data(ptr, shm_varpos);
Reproduce code:
---------------
-----
Expected result:
----------------
------
Actual result:
--------------
--------
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=47721&edit=1