#48740 [Asn->Fbk]: PHAR install fails when INSTALL_ROOT is not the final install location

ID: 48740 Updated by: cellog@php.net Reported By: james dot cohen at digitalwindow dot com -Status: Assigned +Status: Feedback Bug Type: PHAR related Operating System: CentOS release 5.3 PHP Version: 5.3.0 Assigned To: cellog New Comment: Please try using this snapshot: http://snaps.php.net/php5.3-latest.tar.gz For Windows: http://windows.php.net/snapshots/ Previous Comments: ------------------------------------------------------------------------ [2009-07-23 15:33:47] cellog@php.net hi, that actually should be: --- php-5.3.0/ext/phar/Makefile.frag 2009-06-30 15:01:38.000000000 +0100 +++ php-5.3.0/ext/phar/Makefile.frag.symlink 2009-06-30 15:05:27.000000000 +0100 @@ -43,4 +43,4 @@ $(builddir)/phar.phar: $(builddir)/phar. install-pharcmd: pharcmd -@$(mkinstalldirs) $(INSTALL_ROOT)$(bindir) $(INSTALL) $(builddir)/phar.phar $(INSTALL_ROOT)$(bindir) - $(LN_S) -f $(INSTALL_ROOT)$(bindir)/phar.phar $(INSTALL_ROOT)$(bindir)/phar + $(LN_S) -f $(bindir)/phar.phar $(INSTALL_ROOT)$(bindir)/phar Otherwise the symbolic link will be to any file phar.phar in the path and not specifically to our phar.phar ------------------------------------------------------------------------ [2009-06-30 14:16:48] james dot cohen at digitalwindow dot com --- php-5.3.0/ext/phar/Makefile.frag 2009-06-30 15:01:38.000000000 +0100 +++ php-5.3.0/ext/phar/Makefile.frag.symlink 2009-06-30 15:05:27.000000000 +0100 @@ -43,4 +43,4 @@ $(builddir)/phar.phar: $(builddir)/phar. install-pharcmd: pharcmd -@$(mkinstalldirs) $(INSTALL_ROOT)$(bindir) $(INSTALL) $(builddir)/phar.phar $(INSTALL_ROOT)$(bindir) - $(LN_S) -f $(INSTALL_ROOT)$(bindir)/phar.phar $(INSTALL_ROOT)$(bindir)/phar + $(LN_S) -f phar.phar $(INSTALL_ROOT)$(bindir)/phar ------------------------------------------------------------------------ [2009-06-30 14:00:24] james dot cohen at digitalwindow dot com Description: ------------ When you run make install to install PHAR to a location other than the final build location an error occurs. Building an RPM within a build root is a good example of when this might occur. The bin/phar symbolic link point will point to the build root rather than the install root. php-5.3.0/ext/phar/Makefile.frag Line 46 reads: $(LN_S) -f $(INSTALL_ROOT)$(bindir)/phar.phar $(INSTALL_ROOT)$(bindir)/phar To correct the bug the line should be modified to the following $(LN_S) -f phar.phar $(INSTALL_ROOT)$(bindir)/phar This should be safe as both are in the same directory ($(INSTALL_ROOT)$(bindir)/phar) ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=48740&edit=1