#48189 [Asn->Csd]: ibase_execute error in return param

From: Date: Sat, 25 Jul 2009 23:41:00 +0000
Subject: #48189 [Asn->Csd]: ibase_execute error in return param
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-140251@lists.php.net to get a copy of this message
 ID:               48189
 Updated by:       kalle@php.net
 Reported By:      maxwer at ukr dot net
-Status:           Assigned
+Status:           Closed
 Bug Type:         InterBase related
 Operating System: Win2000SP4
 PHP Version:      5.2.9
 Assigned To:      kalle
 New Comment:

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Fixed in 5.3.1


Previous Comments:
------------------------------------------------------------------------

[2009-07-25 23:40:22] svn@php.net

Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=286332
Log: BFN #48189

------------------------------------------------------------------------

[2009-07-25 23:39:22] svn@php.net

Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=286331
Log: MFB: Fixed bug #48189 (ibase_execute error in return param)

------------------------------------------------------------------------

[2009-07-25 23:37:48] svn@php.net

Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=286330
Log: Fixed bug #48189 (ibase_execute error in return param)

------------------------------------------------------------------------

[2009-07-25 02:57:56] felipe@php.net

The patch is fine, Kalle. (Not for 5.2.x though)
But we need to warn in the documentation about someone relying in the
'if (ibase_execute())' check. As the function is intended to return
FALSE on error, and the "0 " has been used until the moment to be an
"zero true".


------------------------------------------------------------------------

[2009-07-22 08:23:31] kalle@php.net

Could you please try with this patch against PHP_5_3 svn:
Index: ibase_query.c
===================================================================
--- ibase_query.c	(revision 284410)
+++ ibase_query.c	(working copy)
@@ -1031,8 +1031,7 @@
 				if (affected_rows) {
 					RETVAL_LONG(affected_rows);
 				} else {
-					/* this return value evaluates to bool(true) and to int(0) */
-					RETVAL_STRINGL("0 ",2,1);
+					RETVAL_TRUE;
 				}
 				break;
 			}


------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/48189

-- 
Edit this bug report at http://bugs.php.net/?id=48189&edit=1



Thread (11 messages)

« previous php.bugs (#140251) next »