#48640 [Asn->Csd]: compilation broken for NetWare because of wrong ifdefs

From: Date: Wed, 26 Aug 2009 02:17:09 +0000
Subject: #48640 [Asn->Csd]: compilation broken for NetWare because of wrong ifdefs
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-141518@lists.php.net to get a copy of this message
 ID:               48640
 Updated by:       guenter@php.net
 Reported By:      guenter@php.net
-Status:           Assigned
+Status:           Closed
 Bug Type:         Zip Related
 Operating System: NetWare
 PHP Version:      5.2.10
 Assigned To:      guenter
 New Comment:

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------

[2009-08-26 02:16:42] svn@php.net

Automatic comment from SVN on behalf of guenter
Revision: http://svn.php.net/viewvc/?view=revision&revision=287723
Log: fix bug #48640: cleaned up ifdef whoes, removed duplicate code.

------------------------------------------------------------------------

[2009-06-23 23:24:35] guenter@php.net

Here's a 'diff -wu php_zip.c.orig php_zip.c' which probably shows
better what the patch really does:
http://www.gknw.net/~gknw/php_zip.c.diff.html

------------------------------------------------------------------------

[2009-06-23 13:52:30] pajoye@php.net

Pls commit yourself :)

------------------------------------------------------------------------

[2009-06-23 12:44:09] pajoye@php.net

Ilia, he can commit himself now. Afaics, this patch is only a cleanup
for other platforms, where the #ifdef clauses contain the same code.

------------------------------------------------------------------------

[2009-06-23 12:39:47] iliaa@php.net

Why are the win32 defines being removed in the patch?

------------------------------------------------------------------------

The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
    http://bugs.php.net/48640

-- 
Edit this bug report at http://bugs.php.net/?id=48640&edit=1



Thread (6 messages)

« previous php.bugs (#141518) next »