#49572 [NEW]: use of C++ style comments causes build failure

From: mamfelt at gmail dot com Operating system: AIX 6.1 PHP version: 5.2SVN-2009-09-16 (snap) PHP Bug Type: Compile Failure Bug description: use of C++ style comments causes build failure Description: ------------ A C++ style comment in main/streams/memory.c causes a build failure. Reproduce code: --------------- in /php5.2-200909161430/main/streams/memory.c: self->innerstream = php_stream_memory_create_rel(mode); php_stream_auto_cleanup(self->innerstream); // do not warn if innerstream is GC'ed before stream ((php_stream_memory_data*)self->innerstream->abstract)->owner_ptr = &self->innerstream; Corrected as: self->innerstream = php_stream_memory_create_rel(mode); php_stream_auto_cleanup(self->innerstream); /* do not warn if innerstream is GC'ed before stream */ ((php_stream_memory_data*)self->innerstream->abstract)->owner_ptr = &self->innerstream; Expected result: ---------------- A normal build Actual result: -------------- prj/php5.2-200909161430/main/streams/memory.c", line 566.53: 1506-046 (S) Syntax error. "/data/home/michael/prj/php5.2-200909161430/main/streams/memory.c", line 566.105: 1506-209 (S) Character constants must end before the end of a line. "/data/home/michael/prj/php5.2-200909161430/main/streams/memory.c", line 566.88: 1506-076 (W) Character constant 'ed before stream' has more than 4 characters. No more than rightmost 4 characters are used. .... -- Edit bug report at http://bugs.php.net/?id=49572&edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=49572&r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=49572&r=trysnapshot53 Try a snapshot (PHP 6.0): http://bugs.php.net/fix.php?id=49572&r=trysnapshot60 Fixed in SVN: http://bugs.php.net/fix.php?id=49572&r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=49572&r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=49572&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=49572&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=49572&r=needscript Try newer version: http://bugs.php.net/fix.php?id=49572&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=49572&r=support Expected behavior: http://bugs.php.net/fix.php?id=49572&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=49572&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=49572&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=49572&r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=49572&r=php4 Daylight Savings: http://bugs.php.net/fix.php?id=49572&r=dst IIS Stability: http://bugs.php.net/fix.php?id=49572&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=49572&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=49572&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=49572&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=49572&r=mysqlcfg