Bug #18375 Updated: addslashes doesn't fit for multibyte string

ID: 18375 Updated by: sniper@php.net Reported By: Xuefer@21cn.com Status: Feedback Bug Type: MySQL related Operating System: win2k PHP Version: 4.2.1 New Comment: Everyplace where php_addslashes is used, it's only used if the magic_quotes_* stuff is turned on (magic_quotes_runtime)..or is there someplace where it is used anyway? Previous Comments: ------------------------------------------------------------------------ [2002-07-17 01:41:20] xuefer@21cn.com there're some other things to say. i always get my code runnign under magic_quote_* off but php_addslashes()(PHPAPI) is widely used internally there is a configuration flag "magic_quotes_sybase" for special to sybase, will there a flag for warping php_addslashes to mysql_escape_string ? ------------------------------------------------------------------------ [2002-07-17 01:39:36] sniper@php.net Can you please try this snapshot: http://snaps.php.net/win32/php4-win32-latest.zip The bundled mysql lib was updated recently..unfortunately I'm not able to test this as I don't have windowds machine to test it.. About magic_quotes_*: I personally would like to see them removed altogether... ------------------------------------------------------------------------ [2002-07-17 01:34:32] Xuefer@21cn.com of cos magic_quote_* can be turned off, but how about turnning on? and the binary version os php or bundled libmysql in php is out dated both addslashes() and mysql_escape_string() didn't help me to insert binary data into mysql databse :( may be a bug of mysql 4 ?.... after all, i'm not expert to those sources :( ------------------------------------------------------------------------ [2002-07-16 16:23:01] sniper@php.net magic_quotes_* can be turned off, no bug there. And if I understood correctly, mysql_escape_string() works fine with multibyte data? So where's the bug here? Sounds more like documentation problem.. ------------------------------------------------------------------------ [2002-07-16 15:48:47] Xuefer@21cn.com as described in manual, addslashes is for prepairing database queries but it don't fit for mysql4.x when charset is set to multibyte, e.g. GBK escape/unescaping multibyte string is process differently in mysql-client/mysqld (btw: i dunno why it need to do such way) when a binary data addslashes() by php sent to mysqlserver, myodbc_remove_escape mysql_escape_string need upgraded mysql library but addslashes is used to process GPC when magic_quote is on ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=18375&edit=1