#49585 [Opn->Asn]: date_format buffer not long enough for >4 digit years

ID: 49585 Updated by: felipe@php.net Reported By: aharvey@php.net -Status: Open +Status: Assigned Bug Type: Date/time related Operating System: Linux (Ubuntu 9.04) PHP Version: 5.3SVN-2009-09-18 (SVN) -Assigned To: +Assigned To: derick Previous Comments: ------------------------------------------------------------------------ [2009-09-18 09:28:23] aharvey@php.net Gah, just found another corner case while writing the PHPT case. The "short" day name used by 'r' may not actually be three characters in all cases -- 'Unknown' can be returned. Ergo, we need another four characters. Revised patch: http://www.adamharvey.name/stuff/date-format-buffer-64-revised.patch PHPT test case: http://www.adamharvey.name/stuff/bug49585.phpt ------------------------------------------------------------------------ [2009-09-18 09:10:18] aharvey@php.net By which I mean http://www.adamharvey.name/stuff/date-format-buffer-64.patch -- the PHP bug tracker's autolinking picked up the full stop. :) ------------------------------------------------------------------------ [2009-09-18 09:09:32] aharvey@php.net Actually, I'm running a 64 bit machine anyway; the point is that the explicit (int) cast will be 32 bit regardless on an LP64 or LLP64 architecture. Nevertheless, a patch that can definitely handle 64 bit ints is at http://www.adamharvey.name/stuff/date-format-buffer-64.patch. ------------------------------------------------------------------------ [2009-09-18 09:01:48] derick@php.net Oh, and a few phpt test cases would be awesome too :-) ------------------------------------------------------------------------ [2009-09-18 09:00:53] derick@php.net Actually, 64bit machines are getting pretty much common, so could you please update your patch? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/49585 -- Edit this bug report at http://bugs.php.net/?id=49585&edit=1