#50496 [Csd->Asn]: Use of <stdbool.h> is valid only in a c99 compilation environment.

ID: 50496 Updated by: pajoye@php.net Reported By: alexander at skwar dot name -Status: Closed +Status: Assigned Bug Type: Compile Failure Operating System: Solaris 10, Sparc PHP Version: 5.3SVN-2009-12-16 (snap) Assigned To: srinatar New Comment: Pls don't open another bug for the exact same problem. If the header is only available in c99 and c99 can have bad side effects, why not define manually on Solaris what is necessary for the code to work and be done with this problem? Previous Comments: ------------------------------------------------------------------------ [2009-12-16 20:50:29] srinatar@php.net [ see also bug #50497 ] thanks for taking time to report this issue. the fix for this issue is now integrated. mean while, your suggested work around (export CFLAGS=- xc99=all) should be acceptable. - Sriram ------------------------------------------------------------------------ [2009-12-16 20:49:08] svn@php.net Automatic comment from SVN on behalf of srinatar Revision: http://svn.php.net/viewvc/?view=revision&revision=292222 Log: - Fixed bug #50496 (Use of <stdbool.h> is valid only in a c99 compilation environment.) ------------------------------------------------------------------------ [2009-12-16 20:45:51] johannes@php.net This is changing it globally, no? - Might this have negative effects (I don't know if C99 breaks C89 code in anyway, while in general I'd like to move to C99 due to the types and some other stuff it offers) And might we have trouble with other non-gcc platforms? ------------------------------------------------------------------------ [2009-12-16 20:12:39] pajoye@php.net hi, Thanks for the quick work :) As long as it affects only Solaris/OpenSolaris, go ahead with the commit. It is not necessary to backport this fix to 5.2 as the crypt addition has been done only in 5.3+. ------------------------------------------------------------------------ [2009-12-16 20:10:09] srinatar@php.net Sun Studio compiler does not by default enable ANSIC C99 standard and its extensions and need to be explicitly enabled. ! this patch addresses this patch by enabling ANSIC99 standard. [sriramn@chilidev]'PHP_5_3'>svn diff acinclude.m4 Index: acinclude.m4 =================================================================== --- acinclude.m4 (revision 292219) +++ acinclude.m4 (working copy) @@ -2780,7 +2780,7 @@ AC_MSG_RESULT([no]), SUNCC="yes" GCC="no" - test -n "$auto_cflags" && CFLAGS="-O -xs -xstrconst -zlazyload" + test -n "$auto_cflags" && CFLAGS="-O -xc99=all -xs -xstrconst - zlazyload" GCC="" AC_MSG_RESULT([yes]) ) if no one has any objections, i will commit this patch here is the complete patch Index: trunk/acinclude.m4 =================================================================== --- trunk/acinclude.m4 (revision 292220) +++ trunk/acinclude.m4 (working copy) @@ -2780,7 +2780,7 @@ AC_MSG_RESULT([no]), SUNCC="yes" GCC="no" - test -n "$auto_cflags" && CFLAGS="-O -xs -xstrconst -zlazyload" + test -n "$auto_cflags" && CFLAGS="-O -xc99=all -xs -xstrconst - zlazyload" GCC="" AC_MSG_RESULT([yes]) ) Index: branches/PHP_5_3/acinclude.m4 =================================================================== --- branches/PHP_5_3/acinclude.m4 (revision 292219) +++ branches/PHP_5_3/acinclude.m4 (working copy) @@ -2780,7 +2780,7 @@ AC_MSG_RESULT([no]), SUNCC="yes" GCC="no" - test -n "$auto_cflags" && CFLAGS="-O -xs -xstrconst -zlazyload" + test -n "$auto_cflags" && CFLAGS="-O -xc99=all -xs -xstrconst - zlazyload" GCC="" AC_MSG_RESULT([yes]) ) Index: branches/PHP_5_3/NEWS =================================================================== --- branches/PHP_5_3/NEWS (revision 292219) +++ branches/PHP_5_3/NEWS (working copy) @@ -9,6 +9,8 @@ - Changed "post_max_size" php.ini directive to allow unlimited post size by setting it to 0. (Rasmus) +- Fixed bug #50496 (Use of <stdbool.h> is valid only in a c99 compilation + environment. (Sriram) - Added support for SHA-256 and SHA-512 to php's crypt. (Pierre) - Added realpath_cache_size() and realpath_cache_get() functions. (Stas) - Added FILTER_FLAG_STRIP_BACKTICK option to the filter extension. (Ilia) I will enable xc99=all option in php 5.2 branch after 5.2.12 is released. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/50496 -- Edit this bug report at http://bugs.php.net/?id=50496&edit=1