#50537 [Opn->Fbk]: llabs() not defined but is defined..
| From: | jani@php.net | Date: | Mon, 21 Dec 2009 10:14:34 +0000 |
| Subject: | #50537 [Opn->Fbk]: llabs() not defined but is defined.. | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-145953@lists.php.net to get a copy of this message | ||
ID: 50537
Updated by: jani@php.net
-Summary: BugID: 50226
Reported By: dax at enst dot fr
-Status: Open
+Status: Feedback
Bug Type: Compile Failure
Operating System: Solaris9
PHP Version: 5.3.1
New Comment:
1. Fix the summary. No idea what your problem really is.
2. Yes, I'm quite sure we should not define llabs() if it's already
defined. WHAT exactly is the error you get?
Previous Comments:
------------------------------------------------------------------------
[2009-12-21 02:46:29] aharvey@php.net
FTR, I believe the OP is actually referring to the fix for bug #50266,
which was revision 291371.
------------------------------------------------------------------------
[2009-12-20 15:23:00] dax at enst dot fr
Description:
------------
IMHO, it seems to me that the fix of the Bug-id 50226 by Jani in
php_date.c is wrong.
Really, are you sure at line 38 it is #ifndef HAVE_LLABS
and not #ifdef HAVE_LLABS ?
With #ifdef the compilation runs finely until the end.
Please can you check ?
Philippe
Reproduce code:
---------------
#ifdef PHP_WIN32
# include "win32/php_stdint.h"
#endif
#ifdef HAVE_LLABS
# if defined(__GNUC__) && __GNUC__ < 3
static __inline __int64_t llabs( __int64_t i ) { return i >= 0 ? i :
-i; }
# elif defined(NETWARE) && defined(__MWERKS__)
static __inline long long llabs( long long i ) { return i >= 0 ? i :
-i; }
# endif
#endif
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=50537&edit=1