ID: 50930
Updated by: derick@php.net
Reported By: nathan dot kessler at hushmail dot me
-Status: Assigned
+Status: Closed
Bug Type: Date/time related
Operating System: SuSE 7.3 i386 / gcc version 2.95
PHP Version: 5.*, 6
Assigned To: derick
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Fixed in rev. 294854 by always relying on our own function.
Previous Comments:
------------------------------------------------------------------------
[2010-02-10 16:23:32] svn@php.net
Automatic comment from SVN on behalf of derick
Revision: http://svn.php.net/viewvc/?view=revision&revision=294854
Log: - Added a test case for bug #45866
- Fixed tests: oo_002, bug46268
- Fixed bug #50930 (Wrong date by php_date.c patch with ancient
gcc/glibc
versions).
- Make sure faulty strings passed to DateTime::modify() notify the
user.
- Revert fix for bug #50392 as it was fixed wrongly without a proper
test case.
- Fixed a bug with the 'r' formatting function as the default buffer
size that
was allocated only fit 4 digit years.
------------------------------------------------------------------------
[2010-02-04 18:57:53] jani@php.net
I'll leave it for Derick to decide what to do. I suggest removing the
whole check from config.m4 and replacing the llabs() stuff with some own
macro/function used always for any and all compilers and systems.
------------------------------------------------------------------------
[2010-02-04 02:33:49] kmcgrail at apache dot org
In my previous comment, I referred to the wrong patch. I meant to say
remove 291371. The cookie warning from 286508 is good and valid IMO.
OK, so I believe the patch in 291371 definitely is causing the issue in
combination with older GCC's. Here's the testing I've done:
PHP 5.2.12 compiled by gcc 3.2.3 - SquirrelMail 1.2.19 works as well as
PHPMyAdmin 2.11.10.
PHP 5.2.12 compiled by gcc 2.9.6 - SM 1.2.19 is broken with the error
"You must be logged in to access this page."
PHPMyAdmin sporadically triggers "Warning: Expiry date cannot have a
year greater then 9999"
Finally, PHP 5.2.12 compiled with revision 291371 removed with GCC 2.96
- PHPMyadmin & SquirrelMail works.
So I think the issue is with the llabs call as you expected and my
experience confirms it. If you have a patch you want me to test, let me
know.
------------------------------------------------------------------------
[2010-02-03 23:28:37] jani@php.net
Oops, that bug was no warning but an error. So can't really just
revert..
------------------------------------------------------------------------
[2010-02-03 23:26:34] jani@php.net
I'm considering reverting the patch for fixing bug #50266 since that
was only a warning anyway..need to investigate a bit more though.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/50930--
Edit this bug report at http://bugs.php.net/?id=50930&edit=1