#51023 [Opn->Fbk]: ext/filter/tests/046.phpt fails, does not detect int overflow

From: Date: Fri, 12 Feb 2010 16:13:43 +0000
Subject: #51023 [Opn->Fbk]: ext/filter/tests/046.phpt fails, does not detect int overflow
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-147472@lists.php.net to get a copy of this message 
 ID:          51023
 Updated by:  jani@php.net
 Reported By: geissert at debian dot org
-Status:      Open
+Status:      Feedback
 Bug Type:    Filter related
 PHP Version: 5.3.1
 New Comment:

Please try using this snapshot:

  http://snaps.php.net/php5.3-latest.tar.gz
 
For Windows:

  http://windows.php.net/snapshots/




Previous Comments:
------------------------------------------------------------------------

[2010-02-11 23:31:02] geissert at debian dot org

Description:
------------
The filter fails to detect an integer overflow and passes the
FILTER_VALIDATE_INT test. The problem is caused because
php_filter_parse_int uses a long to detect the overflow, which of course
doesn't have the same size of an integer.

This can be fixed by making ctx_value an integer in both
php_filter_parse_int and php_filter_int (and for correctness, not
setting Z_TYPE_P(value) to IS_LONG).


Reproduce code:
---------------
// the current test:
$s = sprintf("%d", PHP_INT_MAX);
var_dump(is_long(filter_var($s, FILTER_VALIDATE_INT)));

$s = sprintf("%.0f", PHP_INT_MAX+1);
var_dump(filter_var($s, FILTER_VALIDATE_INT));

$s = sprintf("%d", -PHP_INT_MAX);
var_dump(is_long(filter_var($s, FILTER_VALIDATE_INT)));

Expected result:
----------------
bool(true)
bool(false)
bool(true)


Actual result:
--------------
bool(true)
int(-2147483648)
bool(true)


------------------------------------------------------------------------


-- 
Edit this bug report at http://bugs.php.net/?id=51023&edit=1

Thread (7 messages)

« previous php.bugs (#147472) next »