#51022 [Fbk->Csd]: getservbyname_basic.phpt has incorrect description and misses a skip case

ID: 51022 Updated by: geissert@php.net Reported By: geissert at debian dot org -Status: Feedback +Status: Closed Bug Type: Network related Operating System: debian sid PHP Version: 5.3.1 New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Previous Comments: ------------------------------------------------------------------------ [2010-02-16 05:38:50] svn@php.net Automatic comment from SVN on behalf of geissert Revision: http://svn.php.net/viewvc/?view=revision&revision=295137 Log: Correct description of getservbyname_basic.phpt (bug #51022) ------------------------------------------------------------------------ [2010-02-12 18:42:49] geissert at debian dot org Maybe because it says: Test function getservby*port*() by *calling it more than or less than its expected arguments* The test does nothing of that :) As to why /etc/services (and friends) wouldn't exist: because it is only required for networking (not going to strongly push that change, though.) ------------------------------------------------------------------------ [2010-02-12 16:26:03] jani@php.net Why would you not have /etc/services and how is the description wrong? (patches are welcome..) ------------------------------------------------------------------------ [2010-02-11 21:29:55] geissert at debian dot org Description: ------------ The description of ext/standard/tests/general_functions/getservbyname_basic.phpt is incorrect, as that's not really what the test is about. Additionally, a SKIP section should be added to skip the test if /etc/services does not exist. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=51022&edit=1