Bug #51740 [Opn->Csd]: acinclude.m4 macro PHP_CHECK_SIZEOF is not properly quoted

Edit report at http://bugs.php.net/bug.php?id=51740&edit=1 ID: 51740 Updated by: felipe@php.net Reported by: dave dot mulford at gmail dot com Summary: acinclude.m4 macro PHP_CHECK_SIZEOF is not properly quoted -Status: Open +Status: Closed Type: Bug Package: Compile Warning Operating System: gentoo linux 2.6.30 PHP Version: 5.3SVN-2010-05-04 (snap) -Assigned To: +Assigned To: felipe New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. Thanks for the patch! ;) Previous Comments: ------------------------------------------------------------------------ [2010-05-05 23:55:46] felipe@php.net Automatic comment from SVN on behalf of felipe Revision: http://svn.php.net/viewvc/?view=revision&revision=299035 Log: - Fixed bug #51740 (acinclude.m4 macro PHP_CHECK_SIZEOF is not properly quoted) Patch by: dave dot mulford at gmail dot com ------------------------------------------------------------------------ [2010-05-04 16:14:20] dave dot mulford at gmail dot com I could not get the system to allow me to upload my patch file, so here it is, in plain text. --- acinclude.m4.original 2010-05-04 13:48:26.000000000 +0000 +++ acinclude.m4 2010-05-04 13:48:37.000000000 +0000 @@ -1095,7 +1095,7 @@ dnl dnl PHP_CHECK_SIZEOF(type, cross-value, extra-headers) dnl -AC_DEFUN(PHP_CHECK_SIZEOF, [ +AC_DEFUN([PHP_CHECK_SIZEOF], [ AC_MSG_CHECKING([size of $1]) _PHP_CHECK_SIZEOF($1, $2, $3, [ AC_DEFINE_UNQUOTED([SIZEOF_]translit($1,a-z,A-Z_), [$]php_cv_sizeof_[]$1, [Size of $1]) ------------------------------------------------------------------------ [2010-05-04 16:10:23] dave dot mulford at gmail dot com Description: ------------ When building an extension I've written, aclocal displays a warning that the macro PHP_CHECK_SIZEOF is "underquoted." I have confirmed this by checking line 1098 of the acinclude.m4 file that gets copied after phpize is run. According to the autoconf documentation, all macros should be surrounded by quotes. http://www.gnu.org/software/autoconf/manual/autoconf.html#Macro- Definitions Expected result: ---------------- No warnings should be displayed when the aclocal command is executed. Actual result: -------------- acinclude.m4:1098: warning: underquoted definition of PHP_CHECK_SIZEOF acinclude.m4:1098: run info '(automake)Extending aclocal' acinclude.m4:1098: or see http://sources.redhat.com/automake/automake.html#Extending-aclocal ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=51740&edit=1