Bug #49819 [Opn->Csd]: STDOUT losing data with posix_isatty()
Edit report at http://bugs.php.net/bug.php?id=49819&edit=1
ID: 49819
Updated by: mike@php.net
Reported by: cschneid at cschneid dot com
Summary: STDOUT losing data with posix_isatty()
-Status: Open
+Status: Closed
Type: Bug
Package: Streams related
PHP Version: 5.2, 5.3, 6
-Assigned To:
+Assigned To: mike
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
Previous Comments:
------------------------------------------------------------------------
[2010-05-18 09:25:31] mike@php.net
Automatic comment from SVN on behalf of mike
Revision: http://svn.php.net/viewvc/?view=revision&revision=299437
Log: * fixed bug #49819: STDOUT losing data with posix_isatty()
------------------------------------------------------------------------
[2009-10-11 09:41:07] Sjoerd@php.net
Could reproduce with PHP 5.3-HEAD.
------------------------------------------------------------------------
[2009-10-09 12:54:53] cschneid at cschneid dot com
--- sapi/cli/php_cli.c (revision 289412)
+++ sapi/cli/php_cli.c (working copy)
@@ -565,6 +565,10 @@
s_err->flags |= PHP_STREAM_FLAG_NO_CLOSE;
#endif
+ s_in->flags |= PHP_STREAM_FLAG_NO_SEEK;
+ s_out->flags |= PHP_STREAM_FLAG_NO_SEEK;
+ s_err->flags |= PHP_STREAM_FLAG_NO_SEEK;
+
s_in_process = s_in;
php_stream_to_zval(s_in, zin);
------------------------------------------------------------------------
[2009-10-09 12:50:19] cschneid at cschneid dot com
Description:
------------
The PHP streams for stdin, stdout and stderr are seekable which results
in php_stream_flush() and seek being called on it.
For some reason php_stream_flush() fails to actually write the data
while still calling seek and resetting the stream position.
Suggested solution:
- Find out why php_stream_flush() fails and fix it (I don't know enough
about it)
- Mark (some? all?) stdio streams as PHP_STREAM_FLAG_NO_SEEK in
sapi/cli/php_cli.c (see patch)
- Mark stdio streams as PHP_STREAM_FLAG_NO_SEEK in
ext/standard/php_fopen_wrapper.c
Reproduce code:
---------------
php -r 'echo "hello1\n"; posix_isatty(STDOUT); echo "hello2\n";'
>out;
cat out
Expected result:
----------------
hello1
hello2
Actual result:
--------------
hello2
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=49819&edit=1
Thread (4 messages)