Bug #52330 [NEW]: __construct() method should always return a new instance

From: Operating system: PHP version: Irrelevant Package: Class/Object related Bug Type: Bug Bug description:__construct() method should always return a new instance Description: ------------ Please see the test script. This should be normal PHP 5.3 class with a good OOP design. In PHP it is possible, that I can call the constructor multiple times, for example: $person = new \My\Person('Jens', 'Mander'); echo sprintf('Name: %s %s', $person->getName(), $person->getSurname()); // Will output "Name: Jens Mander" $person->__construct('John', 'Doe'); echo sprintf('Name: %s %s', $person->getName(), $person->getSurname()); // Will output "Name: John Doe" In my understanding, it is unexpected, that 1) you can access the constructor method in an instantiated object. The constructor should only instantiate the object - when you have the object, there is no need to call it again. If you need something to "reset" your object state, you should implement such a method. 2) If you can call the constructor again, that it will change the object and *not* return a new instance. For example: If you add a "return new \stdClass();" line to your constructor, it will still change the instance you called it from, but now it will also return a "stdClass" - that's inconsistent, isn't it? Test script: --------------- <?php namespace My; class Person { protected $_name = null; protected $_surname = null; /** * Constructor. * * @param string OPTIONAL $name * @param string OPTIONAL $surname * @return \My\Person */ public function __construct($name = null, $surname = null) { if ($name !== null) { $this->setName($name); } if ($surname !== null) { $this->setSurname($surname); } } /** * Returns the name. * * @return null|string Null, when no name was set */ public function getName() { return $this->_name; } /** * Returns the surname. * * @return null|string Null, when no name was set */ public function getSurname() { return $this->_surname; } /** * Set the name. * * @param string $name * @return \My\Person Provides fluent interface * @throws \Exception */ public function setName($name) { if (!is_string($name) || empty($name)) { throw new \Exception('Name cannot be empty and must be a string!'); } $this->_name = $name; return $this; } /** * Set the surname. * * @param string $name * @return \My\Person Provides fluent interface * @throws \Exception When $name isn't a string or empty */ public function setSurname($name) { if (!is_string($name) || empty($name)) { throw new \Exception('Name cannot be empty and must be a string!'); } $this->_surname = $name; return $this; } } Expected result: ---------------- - FATAL error e.g. "Object already constructed!" - The __construct() call should return a *new* object. Actual result: -------------- The __construct() method will work on the object, from where you called it. -- Edit bug report at http://bugs.php.net/bug.php?id=52330&edit=1 -- Try a snapshot (PHP 5.2): http://bugs.php.net/fix.php?id=52330&r=trysnapshot52 Try a snapshot (PHP 5.3): http://bugs.php.net/fix.php?id=52330&r=trysnapshot53 Try a snapshot (trunk): http://bugs.php.net/fix.php?id=52330&r=trysnapshottrunk Fixed in SVN: http://bugs.php.net/fix.php?id=52330&r=fixed Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=52330&r=needdocs Fixed in release: http://bugs.php.net/fix.php?id=52330&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=52330&r=needtrace Need Reproduce Script: http://bugs.php.net/fix.php?id=52330&r=needscript Try newer version: http://bugs.php.net/fix.php?id=52330&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=52330&r=support Expected behavior: http://bugs.php.net/fix.php?id=52330&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=52330&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=52330&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=52330&r=globals PHP 4 support discontinued: http://bugs.php.net/fix.php?id=52330&r=php4 Daylight Savings: http://bugs.php.net/fix.php?id=52330&r=dst IIS Stability: http://bugs.php.net/fix.php?id=52330&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=52330&r=gnused Floating point limitations: http://bugs.php.net/fix.php?id=52330&r=float No Zend Extensions: http://bugs.php.net/fix.php?id=52330&r=nozend MySQL Configuration Error: http://bugs.php.net/fix.php?id=52330&r=mysqlcfg