Bug #52413 [Fbk->Csd]: MySQLi build failure on OS X

Edit report at http://bugs.php.net/bug.php?id=52413&edit=1 ID: 52413 Updated by: aharvey@php.net Reported by: aharvey@php.net Summary: MySQLi build failure on OS X -Status: Feedback +Status: Closed Type: Bug Package: MySQLi related Operating System: Mac OS X 10.6.4 PHP Version: 5.3.3 Assigned To: mysql Block user comment: N New Comment: Looks good to me; with that change, MySQLi builds fine on OS X against an external libmysqlclient. Thanks Andrey! Previous Comments: ------------------------------------------------------------------------ [2010-08-13 11:57:54] andrey@php.net Patch just committed, please use svn or wait at least 2h to get a snapshot from snaps.php.net, for testing. If everything is alright, fix will be part of 5.3.4 . Thanks! ------------------------------------------------------------------------ [2010-08-13 11:57:06] andrey@php.net Automatic comment from SVN on behalf of andrey Revision: http://svn.php.net/viewvc/?view=revision&revision=302179 Log: Fix for bug #52413 MySQLi build failure on OS X ------------------------------------------------------------------------ [2010-07-23 13:42:06] aharvey@php.net The bottom line on this one is that we're now manually including a bunch more libmysql headers in a different order to 5.3.2, and one of the headers we're pulling in is my_global.h. my_global.h checks if HAVE_ULONG is #define'd, and if it's not, attempts to typedef unsigned long ulong. Obviously, if we've previously #define'd ulong to mean "unsigned long" -- say in php_config.h -- this doesn't work out so well. The quick and dirty fix would be to #define HAVE_ULONG 1 just before including my_global.h, but I suspect Andrey (or someone else who works on the various MySQL extensions) will likely have a better idea on this. ------------------------------------------------------------------------ [2010-07-23 13:25:48] aharvey@php.net r300436 looks like the culprit. ------------------------------------------------------------------------ [2010-07-23 13:13:10] aharvey@php.net Also affecting FreeBSD, per bug #52416. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=52413 -- Edit this bug report at http://bugs.php.net/bug.php?id=52413&edit=1