Bug #52636 [Asn->Csd]: php_mysql_fetch_hash writes long value into int

From: Date: Wed, 18 Aug 2010 20:02:55 +0000
Subject: Bug #52636 [Asn->Csd]: php_mysql_fetch_hash writes long value into int
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-153589@lists.php.net to get a copy of this message 
Edit report at http://bugs.php.net/bug.php?id=52636&edit=1

 ID:                 52636
 Updated by:         kalle@php.net
 Reported by:        rein at basefarm dot no
 Summary:            php_mysql_fetch_hash writes long value into int
-Status:             Assigned
+Status:             Closed
 Type:               Bug
 Package:            MySQL related
 Operating System:   Solaris10 on sparc
 PHP Version:        5.3.3
 Assigned To:        kalle
 Block user comment: N

 New Comment:

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.




Previous Comments:
------------------------------------------------------------------------
[2010-08-18 22:00:20] kalle@php.net

Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=302456
Log: Fixed bug #52636 (php_mysql_fetch_hash writes long value into int)

# Tested by rein at basefarm dot no

------------------------------------------------------------------------
[2010-08-18 21:32:19] rein at basefarm dot no

Using the prototype change, all mysql tests succeed for me on
solaris10/sparc, solaris10/x86_64 and redhat4/x86_64 :-)  So from my
point of view it is go ahead with the prototype variant.

------------------------------------------------------------------------
[2010-08-18 21:06:32] kalle@php.net

Just my thought, could try try it out if it works, if not then I guess
we need to suffix the MYSQL_FETCH defines with L to make them a long.

Either way, reply back with your results and ill commit the fix tonight,
thanks :)

------------------------------------------------------------------------
[2010-08-18 20:56:24] rein at basefarm dot no

Yes, probably, thought about that I too.  I discarded it as I just
don´t like to change argument types unless I´m absolutely sure it
doesn´t have any unforseen side-effects.  And I don´t consider my
limited knowledge of php internals to be good enough for that.  Though,
being a static function it should be pretty safe here..

------------------------------------------------------------------------
[2010-08-18 19:54:22] kalle@php.net

Hi, wouldn't it be easier if we just changed the result_type to be a
long in the prototype?

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    http://bugs.php.net/bug.php?id=52636


-- 
Edit this bug report at http://bugs.php.net/bug.php?id=52636&edit=1

Thread (7 messages)

« previous php.bugs (#153589) next »