Bug #14673 Updated: quota ressources

ID: 14673 Updated by: kalowsky@php.net Reported By: kaalh@smol.org -Status: Assigned +Status: Closed Bug Type: IMAP related Operating System: Debian Woody i386 PHP Version: 4.1.0 Assigned To: kalowsky New Comment: This bug has been fixed in CVS. You can grab a snapshot of the CVS version at http://snaps.php.net/. In case this was a documentation problem, the fix will show up soon at http://www.php.net/manual/. In case this was a PHP.net website problem, the change will show up on the PHP.net site and on the mirror sites. Thank you for the report, and for helping us make PHP better. try it and see Previous Comments: ------------------------------------------------------------------------ [2002-07-22 00:25:38] kalowsky@php.net I love you sniper. :) To all those finding this problem, please look at the PHP-Dev mailing lists and try applying the patch I sent out July 18th 2002 to your PHP 4.2.1 It will not fix all the problems you are listing, it will implement imap_get_quotaroot, and adds functionality to imap_getquota for the name of where it gets it's data. If this works well enough for everyone I can easily implement a fix for the symptoms mentioned below. Do please test. ------------------------------------------------------------------------ [2002-07-06 18:55:40] sniper@php.net Assigning to Dan, as he was working on with some other quota stuf. ------------------------------------------------------------------------ [2002-07-06 16:34:35] llima@imagelink.com.br The patch does work. Actually, it works exactly as advertised. Now imap_get_quota() gets only the value returned by the STORAGE resource and ignores the rest. ------------------------------------------------------------------------ [2002-07-06 15:09:51] php@tcs.eng.br My bad. The problem is really on php_imap.c, as noted by kaalh@smol.org. I have produced a patch to "fix" the behavior reported by llima@imagelink.com.br. I can't produce a patch to report all the resources as kaalh@smol.org suggested because that would break the compatibility :-/. Anyway, here's the (small) patch: --- php_imap.c Wed Apr 24 12:30:16 2002 +++ php_imap_fixed.c Sat Jul 6 15:47:55 2002 @@ -374,8 +374,12 @@ /* this should only be run through once */ for (; qlist; qlist = qlist->next) { - IMAPG(quota_usage) = qlist->usage; - IMAPG(quota_limit) = qlist->limit; + if (!strcmp(qlist->name, "STORAGE")) + { + IMAPG(quota_usage) = qlist->usage; + IMAPG(quota_limit) = qlist->limit; + break; + } } } /* }}} */ Suggestions or comments, please mail me. I haven't tested the patch yet, BTW!! But my good friend is testing it for me and I'll ask him to post the results here. :) ------------------------------------------------------------------------ [2002-07-06 11:27:53] php@tcs.eng.br It appears to me that the error is on the IMAP library: php_imap.c:1031:if(!imap_getquota(imap_le_struct->imap_stream, Z_STRVAL_PP(qroot))) { imap_getquota() is implemented by the IMAP library. I'll try and see if I can find the error on the library and then post a patch. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/14673 -- Edit this bug report at http://bugs.php.net/?id=14673&edit=1