Bug #51769 [Asn->Csd]: the problem of fpm_conf.c

From: Date: Sat, 21 Aug 2010 06:27:56 +0000
Subject: Bug #51769 [Asn->Csd]: the problem of fpm_conf.c
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-153683@lists.php.net to get a copy of this message 
Edit report at http://bugs.php.net/bug.php?id=51769&edit=1

 ID:                 51769
 Updated by:         fat@php.net
 Reported by:        lxltiancai at 126 dot com
 Summary:            the problem of fpm_conf.c
-Status:             Assigned
+Status:             Closed
 Type:               Bug
 Package:            *General Issues
 Operating System:   ubuntu 9.10
 PHP Version:        5.3.2
 Assigned To:        fat
 Block user comment: N

 New Comment:

This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

This has been fixed in revision 299141


Previous Comments:
------------------------------------------------------------------------
[2010-05-08 11:53:38] kalle@php.net

Hmm I meant try a snapshot from trunk where php-fpm is actively
developed. I belive a similar bug if not the same was just fixed in
trunk today

------------------------------------------------------------------------
[2010-05-08 11:52:45] kalle@php.net

Please try using this snapshot:

  http://snaps.php.net/php6.0-latest.tar.gz
 
For Windows:

  http://windows.php.net/snapshots/



------------------------------------------------------------------------
[2010-05-08 04:58:16] lxltiancai at 126 dot com

Description:
------------
when i start php-fpm,i met the fellowing message:
[pool www] start_servers(18) must not be less than min_spare_servers(30)
and not greater than max_spare_servers(30)

but in fact,the value of min_spare_servers is 5;

Test script:
---------------
there is something wrong in line 459-460 of fpm_conf.c
i think the correct code shoule be:


			} else if (config->pm_start_servers < config->pm_min_spare_servers ||
config->pm_start_servers > config->pm_max_spare_servers) {
				zlog(ZLOG_STUFF, ZLOG_ALERT, "[pool %s] start_servers(%d) must not
be less than min_spare_servers(%d) and not greater than
max_spare_servers(%d)", wp->config->name, config->pm_start_servers,
config->pm_min_spare_servers, config->pm_max_spare_servers);



------------------------------------------------------------------------



-- 
Edit this bug report at http://bugs.php.net/bug.php?id=51769&edit=1

Thread (5 messages)

« previous php.bugs (#153683) next »