Bug #52546 [Csd->ReO]: pdo_dblib segmentation fault when iterating MONEY values

Edit report at http://bugs.php.net/bug.php?id=52546&edit=1 ID: 52546 Updated by: aharvey@php.net Reported by: rgagnon24 at gmail dot com Summary: pdo_dblib segmentation fault when iterating MONEY values -Status: Closed +Status: Re-Opened Type: Bug Package: PDO related Operating System: CentOS 5.5 PHP Version: 5.2.14 -Assigned To: felipe +Assigned To: aharvey Block user comment: N New Comment: Ilia's approved this for 5.2 as well. I'll merge the fix in later tonight, hopefully. Previous Comments: ------------------------------------------------------------------------ [2010-08-19 20:59:43] rgagnon24 at gmail dot com As an FYI. I've been able to confirm the r302196 commit does resolve the issue in 5.3. I know 5.2 is closed for fixes, but to leave a note for anyone that wishes to manually patch their copy, this does fix it for the released 5.2.14 as well. The only change I would suggest is maybe using sizeof(DBFLT8) in place of the hard-coded "8" integer in the call to dbconvert() ------------------------------------------------------------------------ [2010-08-14 00:16:37] felipe@php.net Just to inform, the fix for this bug was committed just for 5.3 branch. The trunk branch has a bit different code, due some others bugs fixes trunk-only. And 5.2 branch is just accepting security bug fixes. ------------------------------------------------------------------------ [2010-08-14 00:14:05] felipe@php.net This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. rgagnon24 and preben: the spprintf() function already allocates the memory, this is not the problem... The problem is that the function expect char** and I was passing char*. It must be fixed now. Thanks for the testing. ------------------------------------------------------------------------ [2010-08-14 00:12:39] felipe@php.net Automatic comment from SVN on behalf of felipe Revision: http://svn.php.net/viewvc/?view=revision&revision=302196 Log: - Fixed the fix for bug #52546 ------------------------------------------------------------------------ [2010-08-13 18:25:28] aharvey@php.net Reopening, given it's apparently still segfaulting. Felipe, can you cast an eye over the new patch, please? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=52546 -- Edit this bug report at http://bugs.php.net/bug.php?id=52546&edit=1