Bug #52908 [Opn->Csd]: Missing data types in function prototype

Edit report at http://bugs.php.net/bug.php?id=52908&edit=1 ID: 52908 Updated by: pajoye@php.net Reported by: jon at humaninternals dot com Summary: Missing data types in function prototype -Status: Open +Status: Closed Type: Bug Package: Compile Failure Operating System: Windows PHP Version: 5.3SVN-2010-09-22 (snap) -Assigned To: +Assigned To: pajoye Block user comment: N New Comment: Yes, that's correct. I fixed it but forgot to apply to the svn repo. Done now. Thanks for your report! Previous Comments: ------------------------------------------------------------------------ [2010-09-22 23:28:39] pajoye@php.net Automatic comment from SVN on behalf of pajoye Revision: http://svn.php.net/viewvc/?view=revision&revision=303693 Log: - Fix #52908, fix declaration ------------------------------------------------------------------------ [2010-09-22 22:10:05] jon at humaninternals dot com Description: ------------ While trying to compile (using MSVC 2010) an extension against the latest PHP snap (php5.3-201009221830) I encountered multiple errors at the tsrm_virtual_cwd.h file (as stated below) The line reads: CWD_API int php_sys_readlink(link, target, target_len); It seems this was comitted in http://svn.php.net/viewvc? view=revision&revision=303256 I might be wrong here but it is my understanding that prototypes must include the data types of its arguments as the function itself reads the line should be: CWD_API int php_sys_readlink(const char *link, char *target, size_t target_len); This seems to solve the problem. Expected result: ---------------- Successful Compilation Actual result: -------------- \php5.3-201009220630\TSRM\tsrm_virtual_cwd.h(137): error C2065: 'link' : undeclared identifier \php5.3-201009220630\TSRM\tsrm_virtual_cwd.h(137): error C2065: 'target' : undeclared identifier \php5.3-201009220630\TSRM\tsrm_virtual_cwd.h(137): error C2065: 'target_len' : undeclared identifier \php5.3-201009220630\TSRM\tsrm_virtual_cwd.h(137): error C2491: 'php_sys_readlink' : definition of dllimport data not allowed \php5.3-201009220630\TSRM\tsrm_virtual_cwd.h(137): error C2078: too many initializers ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=52908&edit=1