Bug #53338 [Asn->Csd]: DTrace build config broken by Rev 305329

Edit report at http://bugs.php.net/bug.php?id=53338&edit=1 ID: 53338 Updated by: jani@php.net Reported by: mike at harschsystems dot com Summary: DTrace build config broken by Rev 305329 -Status: Assigned +Status: Closed Type: Bug Package: Compile Failure Operating System: Solaris and OS X PHP Version: trunk-SVN-2010-11-18 (snap) Assigned To: jani Block user comment: N Private report: N New Comment: Fixed now in SVN. Tested with OSX though, but should work the same on solaris. Previous Comments: ------------------------------------------------------------------------ [2010-11-18 17:02:38] jani@php.net Automatic comment from SVN on behalf of jani Revision: http://svn.php.net/viewvc/?view=revision&revision=305508 Log: - One more fix for bug #53338 (when copying stuff from other macros, do it all the way.. :) ------------------------------------------------------------------------ [2010-11-18 16:34:04] mike at harschsystems dot com 2.) I think it was main/main.c which includes zend_dtrace.h which includes zend_dtrace_gen.h, but this problem seems to be fixed by placing the 'dtrace -h' line earlier in the Makefile (which now seems to be the case as of 201011181330). 3.) http://pastebin.com/33TJyLC2 - see line 498. I was able to work around this problem by changing the following line in acinclude.m4: dtrace -h -C -s $ac_srcdir[$]ac_provsrc -o \$[]@ && \$(SED) -ibak 's,PHP_,DTRACE_,g' \$[]@ to dtrace -h -C -s $abs_srcdir/[$]ac_provsrc -o \$[]@ && \$(SED) -ibak 's,PHP_,DTRACE_,g' \$[]@ Once this is fixed, the build appears to work on both Solaris and OS X using Rev 305487. ------------------------------------------------------------------------ [2010-11-18 14:37:45] dsp@php.net 1) So providerdesc.o is only build and linked with when under Solaris? yes because dtrace on Solaris generates stubs that need to be compiled in. On Mac OS the necessary switch to generate providerdesc.o doesn't exist on Mac OS. ------------------------------------------------------------------------ [2010-11-18 11:11:38] jani@php.net Automatic comment from SVN on behalf of jani Revision: http://svn.php.net/viewvc/?view=revision&revision=305487 Log: - Fixed DTrace support in MacOSX (bug #53338) ------------------------------------------------------------------------ [2010-11-18 09:53:03] jani@php.net 1) So providerdesc.o is only build and linked with when under Solaris? 2) What in Makefile did depend on the header file before it was created? 3) I need the generated Makefile you got with current trunk (without your patch!) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=53338 -- Edit this bug report at http://bugs.php.net/bug.php?id=53338&edit=1