Bug #53423 [Bgs]: mysql_statement.c uses C99 syntax

Edit report at http://bugs.php.net/bug.php?id=53423&edit=1 ID: 53423 User updated by: jd at cpanel dot net Reported by: jd at cpanel dot net Summary: mysql_statement.c uses C99 syntax Status: Bogus Type: Bug Package: PDO related Operating System: Linux PHP Version: 5.3SVN-2010-11-29 (SVN) Block user comment: N Private report: N New Comment: Thanks for the pointer in the right direction. The problem only happens when compiling against MySQL 4.0. When using MySQL 4.1 and above it compiles correctly. Previous Comments: ------------------------------------------------------------------------ [2010-11-29 17:18:40] johannes@php.net Oh and one more comment: Old versions of gcc are quite liberal with their C iterpretation. Modern versions provide options to check this more strictly (see -W options in the docs) if you want. Other compilers might do even better. ------------------------------------------------------------------------ [2010-11-29 17:14:51] johannes@php.net The actual issue is not C99 or such but that you are using an outdated version of libmsql. You probabl might be successfull when using mysqlnd (--with-mysql=mysqlnd --with-msqli=mysqlnd --with-pdo-mysql=msqlnd) or updating your libmysql version. The C99 macros are only used when using --enable-debug and GCC is detected. ------------------------------------------------------------------------ [2010-11-29 17:13:40] jd at cpanel dot net Also, to be clear, the compile that failed was linking with libmysqlclient (MySQL 4.0.27), not mysqlnd. As far as I can tell though, this has no bearing on the compile failure. ------------------------------------------------------------------------ [2010-11-29 17:07:25] jd at cpanel dot net Just to be clear, the idea that RedHat 7.3 isn't supported is fine with me. It's an ancient system and supporting it shouldn't factor into anyone else's decision making. I always test with RedHat 7.3 because GCC 2.95 points out these types of bugs that many modern compilers allow without complaint. I'm a little concerned that PHP is going to suddenly start requiring a C99 compatible compiler without testing the compiler for C99 support or putting the compiler into C99 mode though. PHP 5.3.3 did not require a C99 compatible compiler as far as I'm aware. ------------------------------------------------------------------------ [2010-11-29 16:58:49] uw@php.net PS: Don't get me wrong when I say "from a MySQL perspective". Of course, php.net can overrule me but "we MySQL guys" are the ones doing most of the work on mysqlnd. So, "from a maintainer perspective", even with my php.net hat on, ... ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at http://bugs.php.net/bug.php?id=53423 -- Edit this bug report at http://bugs.php.net/bug.php?id=53423&edit=1