Bug #53442 [NEW]: [fix provided] configure --with-iconv=DIR fails due to two faulty tests

From: Date: Wed, 01 Dec 2010 21:50:50 +0000
Subject: Bug #53442 [NEW]: [fix provided] configure --with-iconv=DIR fails due to two faulty tests
Groups: php.bugs 
Request: Send a blank email to php-bugs+get-156664@lists.php.net to get a copy of this message 
From:             
Operating system: linux
PHP version:      5.2SVN-2010-12-01 (snap)
Package:          Compile Failure
Bug Type:         Bug
Bug description:[fix provided] configure --with-iconv=DIR fails due to two faulty tests

Description:
------------
when trying to cross-compile configure picked up the host iconv, not the
target one, resulting in wrong paths later on and configure failing.

configure was called with configure --with-iconv=DIR (where DIR is the dir
to find the iconv stuff).

This fails at two places. First one is due to a faulty test in
acinclude.m4
It tests PHP_ICONV against "yes". However PHP_ICONV in my case contains the
path so we should test against not "no"
(PHP_ICONV can be a dir because otherwise this code later on would not make
any sense:     for i in $PHP_ICONV /usr/local /usr; do )

The following patch is for 5.2.13, but I have verified it is also in the
5.2 snap from today.

Index: php-5.2.13/acinclude.m4
===================================================================
--- php-5.2.13.orig/acinclude.m4
+++ php-5.2.13/acinclude.m4
@@ -2430,7 +2430,8 @@ AC_DEFUN([PHP_SETUP_ICONV], [
   dnl
   dnl Check libc first if no path is provided in --with-iconv
   dnl
-  if test "$PHP_ICONV" = "yes"; then
+  dnl must check against no, not against yes as PHP_ICONV can also include
a path, which implies yes
+  if test "$PHP_ICONV" != no"; then
     AC_CHECK_FUNC(iconv, [
       found_iconv=yes
     ],[



-- 
Edit bug report at http://bugs.php.net/bug.php?id=53442&edit=1
-- 
Try a snapshot (PHP 5.2):            http://bugs.php.net/fix.php?id=53442&r=trysnapshot52
Try a snapshot (PHP 5.3):            http://bugs.php.net/fix.php?id=53442&r=trysnapshot53
Try a snapshot (trunk):              http://bugs.php.net/fix.php?id=53442&r=trysnapshottrunk
Fixed in SVN:                        http://bugs.php.net/fix.php?id=53442&r=fixed
Fixed in SVN and need be documented: http://bugs.php.net/fix.php?id=53442&r=needdocs
Fixed in release:                    http://bugs.php.net/fix.php?id=53442&r=alreadyfixed
Need backtrace:                      http://bugs.php.net/fix.php?id=53442&r=needtrace
Need Reproduce Script:               http://bugs.php.net/fix.php?id=53442&r=needscript
Try newer version:                   http://bugs.php.net/fix.php?id=53442&r=oldversion
Not developer issue:                 http://bugs.php.net/fix.php?id=53442&r=support
Expected behavior:                   http://bugs.php.net/fix.php?id=53442&r=notwrong
Not enough info:                     http://bugs.php.net/fix.php?id=53442&r=notenoughinfo
Submitted twice:                     http://bugs.php.net/fix.php?id=53442&r=submittedtwice
register_globals:                    http://bugs.php.net/fix.php?id=53442&r=globals
PHP 4 support discontinued:          http://bugs.php.net/fix.php?id=53442&r=php4
Daylight Savings:                    http://bugs.php.net/fix.php?id=53442&r=dst
IIS Stability:                       http://bugs.php.net/fix.php?id=53442&r=isapi
Install GNU Sed:                     http://bugs.php.net/fix.php?id=53442&r=gnused
Floating point limitations:          http://bugs.php.net/fix.php?id=53442&r=float
No Zend Extensions:                  http://bugs.php.net/fix.php?id=53442&r=nozend
MySQL Configuration Error:           http://bugs.php.net/fix.php?id=53442&r=mysqlcfg

Thread (5 messages)

« previous php.bugs (#156664) next »