Bug #35681 [Com]: xmlwriter has non-ansi comments

Edit report at http://bugs.php.net/bug.php?id=35681&edit=1 ID: 35681 Comment by: jihoy at admin dot com Reported by: to2958 at sbc dot com Summary: xmlwriter has non-ansi comments Status: Closed Type: Bug Package: XML Writer Operating System: AIX 4.3.3 PHP Version: 5CVS-2005-12-14 (snap) Block user comment: N Private report: N New Comment: Thanks for your great tutorial...I really benefit a lot from the post! http://www.amerisleep.com Previous Comments: ------------------------------------------------------------------------ [2005-12-15 14:58:49] tony2001@php.net This bug has been fixed in CVS. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. Thank you for the report, and for helping us make PHP better. ------------------------------------------------------------------------ [2005-12-15 14:50:35] to2958 at sbc dot com Description: ------------ I obtained the snapshot 200512141330 to see about other problems and run into a new problem with compiling the ext/xmlwriter.c. It doesn't look like that was even part of the stable 5.1.1. I'm running with VAC 4.4.0.3. I got this on make: "/store/php5.1-200512141330/TSRM/tsrm_config_common.h", line 23.1: 1506-224 (I) Incorrect #pragma ignored. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1633.17: 1506-0 46 (S) Syntax error. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1633.26: 1506-0 45 (S) Undeclared identifier not. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1643.9: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1663.9: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1670.9: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1684.1: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1702.17: 1506-0 46 (S) Syntax error. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1702.57: 1506-0 45 (S) Undeclared identifier xmlwriter. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1714.9: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1720.9: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1735.1: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1769.21: 1506-0 45 (S) Undeclared identifier force_string. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1790.1: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1798.1: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1806.1: 1506-27 6 (S) Syntax error: possible missing 'while'? "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1812.93: 1506-0 45 (S) Undeclared identifier module_number. "/store/php5.1-200512141330/ext/xmlwriter/php_xmlwriter.c", line 1821.16: 1506-0 68 (S) Operation between types "void" and "int" is not allowed. make: 1254-004 The error code from the last command is 1. It looks like the comment of // is causing problems a patch is included. This is similiar to other bugs except none are for this file. Mentioned bugs are 1424, 8345, 1267. Reproduce code: --------------- Patch: --- php_xmlwriter.c.orig Wed Dec 14 10:15:16 2005 +++ php_xmlwriter.c Wed Dec 14 10:27:23 2005 @@ -1630,7 +1630,7 @@ #ifdef ZEND_ENGINE_2 if (this) { - // We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here + /* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */ ze_obj = (ze_xmlwriter_object*) zend_object_store_get_object(thi s TSRMLS_CC); } #endif @@ -1699,7 +1699,7 @@ #ifdef ZEND_ENGINE_2 if (this) { - // We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here + /* We do not use XMLWRITER_FROM_OBJECT, xmlwriter init function here */ ze_obj = (ze_xmlwriter_object*) zend_object_store_get_object(thi s TSRMLS_CC); } #endif Expected result: ---------------- I expected it to compile everything. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=35681&edit=1