Bug #53530 [Com]: php_crypt tests gcc version incorrectly due to typo
Edit report at http://bugs.php.net/bug.php?id=53530&edit=1
ID: 53530
Comment by: aaron dot styx at baesystems dot com
Reported by: vapier at gmail dot com
Summary: php_crypt tests gcc version incorrectly due to typo
Status: Closed
Type: Bug
Package: Compile Failure
Operating System: Linux
PHP Version: 5.3.4
Assigned To: cataphract
Block user comment: N
Private report: N
New Comment:
This was supposedly fixed, but I just downloaded the most recent version
of php (5.3.5), and the typo still exists.
Previous Comments:
------------------------------------------------------------------------
[2010-12-12 23:28:05] cataphract@php.net
Fixed. I wonder why the atomic operation is used though, because the
section is protected with a lock.
------------------------------------------------------------------------
[2010-12-12 23:27:04] cataphract@php.net
Automatic comment from SVN on behalf of cataphract
Revision: http://svn.php.net/viewvc/?view=revision&revision=306305
Log: - Fixed bug #53530 (php_crypt tests gcc version incorrectly due to
typo) (vapier at gmail dot com)
------------------------------------------------------------------------
[2010-12-12 22:39:41] vapier at gmail dot com
Description:
------------
the ext/standard/php_crypt_r.c code supports atomic ops, but it tests
for the gcc version incorrectly due to a typo in the define name:
...
#elif (defined(__GNUC__) && (__GNUC__ >= 4 && __GNUC_MINOR >= 2))
__sync_fetch_and_add(&initialized, 1);
...
gcc defines "__GNUC_MINOR__", not "__GNUC_MINOR".
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/bug.php?id=53530&edit=1
Thread (4 messages)