Req #52569 [Com]: Implement "ondemand" process-manager (to allow zero children)

From: Date: Sun, 10 Jul 2011 20:01:30 +0000
Subject: Req #52569 [Com]: Implement "ondemand" process-manager (to allow zero children)
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-161759@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=52569&edit=1

 ID:                 52569
 Comment by:         fat@php.net
 Reported by:        mplomer at gmx dot de
 Summary:            Implement "ondemand" process-manager (to allow zero
                     children)
 Status:             Analyzed
 Type:               Feature/Change Request
 Package:            FPM related
 PHP Version:        5.3.3
 Assigned To:        fat
 Block user comment: N
 Private report:     N

 New Comment:

to post a log, use pastbin or something like that.


Previous Comments:
------------------------------------------------------------------------
[2011-07-10 15:50:17] trollofdarkness at gmail dot com

Ok the V10 patch works :) 

But it seems to be a bit fast-forking... 

With a test pool with Apache2. I got 5 processes launches for a single request (single request, I am
sure there was not any other request, test vhost)

With a test nginx pool, I got 3 processes, but here it's a production website so maybe there
was 3 requests coming together, so I can't tell.

I will try the events.delay = 700 (for instance) and I'll tell you.

If I can't manage to find a way to handle the abondance of forks, I'll post a log.

(by the way, how do you attach a file to your comment ? like a debug log ... )

------------------------------------------------------------------------
[2011-07-10 14:38:04] trollofdarkness at gmail dot com

Thanks for your answers.

@mplomer : Yes, I said it in my first post, dynamic & static modes are still working perfectly.

But I did not set the catch_something_** = yes, and it seems its default value is "no" so
this is probably why it was not working. 

I am going to install the V10 patch and I'll tell you so.

-- Troll

------------------------------------------------------------------------
[2011-07-10 13:52:07] fat@php.net

Here is the v10 of the patch. It corrects the bug trollofdarkness and dbetz have 
found.

In fact the array which is storing event has not been sized up and the event was 
not added. It was working when settings catch_workers_output to yes (but breaks 
this feature).

This should now be OK.

test and report please.

++ jerome

------------------------------------------------------------------------
[2011-07-10 13:49:40] fat@php.net

The following patch has been added/updated:

Patch Name: fpm-ondemand.v10-5.3.patch
Revision:   1310320180
URL:        https://bugs.php.net/patch-display.php?bug=52569&patch=fpm-ondemand.v10-5.3.patch&revision=1310320180

------------------------------------------------------------------------
[2011-07-10 13:49:24] fat@php.net

The following patch has been added/updated:

Patch Name: fpm-ondemand.v10.patch
Revision:   1310320164
URL:        https://bugs.php.net/patch-display.php?bug=52569&patch=fpm-ondemand.v10.patch&revision=1310320164

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=52569


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=52569&edit=1

Thread (61 messages)

« previous php.bugs (#161759) next »