#15630 [Com]: imap_utf7_decode appears to be broken
| From: | gamid at isayev dot net | Date: | Wed, 07 Aug 2002 15:30:23 +0000 |
| Subject: | #15630 [Com]: imap_utf7_decode appears to be broken | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-16182@lists.php.net to get a copy of this message | ||
ID: 15630
Comment by: gamid@isayev.net
Reported By: robert.marchand@umontreal.ca
Status: Feedback
Bug Type: IMAP related
Operating System: SGI Irix 6.5
PHP Version: 4.2.2
New Comment:
1) Patched imap_utf7_decode() returns UTF-16 encoded string. So, to
display string properly you should set charset to 'UTF-16' or convert
UTF-16 string into preferred charset.
2) Current imap_utf7_encode() "converts 8bit data to modified UTF-7
text". Question is what mean "8bit data"?
Right now I'm working on the patch for imap_utf7_encode() to add
support for UTF-16 on input. It will allow do right covertion UTF-7 ->
imap_utf7_decode() -> imap_utf7_encode() -> UTF-7.
Previous Comments:
------------------------------------------------------------------------
[2002-08-07 11:11:29] robert.marchand@umontreal.ca
Hi,
here is what I obtain with the patch applied (php-4.2.2):
---- output from Netscape 4.7: ---------
folder (modified UTF-7): test&AN9ZJw-
mb_convert_encoding test
folder decoded: [testß?]
encoded again: [test&AN9ZJw-]
decoded again: [testß?]
imap_utf7_decode test
folder decoded: [
encoded again: [&AA-t&AA-e&AA-s&AA-t&ANE-Y$]
decoded again: [
-----------------------------
Maybe there is something wrong with my installation here, but even
then, I'm not sure adding zero bytes is the good solution. In my view
it will break every application that now use these functions. At least
this patch should be used only when --enable-mbstring is used.
Thanks.
------------------------------------------------------------------------
[2002-08-07 10:52:28] kalowsky@php.net
Once again, please send your updated patch to php-dev. Thank you.
------------------------------------------------------------------------
[2002-08-06 19:02:27] gamid@isayev.net
JFYI:
cvs -d :pserver:cvsread@cvs.php.net:/repository co php4
cd php4/ext/imap/
cvs update -r 1.112.2.1 php_imap.c
patch php_imap.c _file_with_my_patch_
cvs update -A php_imap.c
cvs ci php_imap.c
As result:
--- php_imap.c 5 Aug 2002 21:53:09 -0000 1.134
+++ php_imap.c 6 Aug 2002 23:00:31 -0000
@@ -2077,14 +2077,14 @@
php_error(E_WARNING, "%s(): Invalid
modified UTF-7 character: `%c'", get_active_function_name(TSRMLS_C),
*inp);
RETURN_FALSE;
} else if (*inp != '&') {
- outlen++;
+ outlen += 2;
} else if (inp + 1 == endp) {
php_error(E_WARNING, "%s(): Unexpected
end of string", get_active_function_name(TSRMLS_C));
RETURN_FALSE;
} else if (inp[1] != '-') {
state = ST_DECODE0;
} else {
- outlen++;
+ outlen += 2;
inp++;
}
} else if (*inp == '-') {
@@ -2134,8 +2134,11 @@
if (*inp == '&' && inp[1] != '-') {
state = ST_DECODE0;
}
- else if ((*outp++ = *inp) == '&') {
- inp++;
+ else {
+ *outp++ = 0x00;
+ if ((*outp++ = *inp) == '&') {
+ inp++;
+ }
}
}
else if (*inp == '-') {
------------------------------------------------------------------------
[2002-08-06 18:40:43] kalowsky@php.net
Please update your patch to the current CVS as I can't seem to find the
make it work against my cvs.
------------------------------------------------------------------------
[2002-08-06 17:41:21] gamid@isayev.net
According CVS only warning messages was changed in the function
imap_utf7_decode().
See diff between 1.134 (latest version of /ext/imap/php_imap.c in the
CVS) and 1.112.2.1 (version included into PHP 4.2.2).
Gamid Isayev
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/15630
--
Edit this bug report at http://bugs.php.net/?id=15630&edit=1