Bug #55313 [Opn->Csd]: Number of retries not set when params specified

Edit report at https://bugs.php.net/bug.php?id=55313&edit=1 ID: 55313 Updated by: felipe@php.net Reported by: kevin at kevinlocke dot name Summary: Number of retries not set when params specified -Status: Open +Status: Closed Type: Bug Package: IMAP related PHP Version: trunk-SVN-2011-07-29 (SVN) -Assigned To: +Assigned To: felipe Block user comment: N Private report: N New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. Thanks for the patch! :) Previous Comments: ------------------------------------------------------------------------ [2011-08-06 00:59:19] felipe@php.net Automatic comment from SVN on behalf of felipe Revision: http://svn.php.net/viewvc/?view=revision&revision=314350 Log: - Fixed bug #55313 (Number of retries not set when params specified) patch by: kevin at kevinlocke dot name ------------------------------------------------------------------------ [2011-07-29 02:58:47] kevin at kevinlocke dot name Description: ------------ It appears that when the params argument was added in commit r293126, the check for argc == 5 was not updated to argc >= 5 at php_imap.c:1230 causing the number of tries/retries to be ignored when 6 arguments are given. Test script: --------------- // Next line causes default (2) retries if connection fails imap_open('{localhost:143/service=imap}', 'user', 'pass', 0, 1, array('DISABLE_AUTHENTICATOR' => 'GSSAPI')); // Next line causes 0 retries if connection fails imap_open('{localhost:143/service=imap}', 'user', 'pass', 0, 1); Expected result: ---------------- Both connection attempts cause 0 retries on failure. Actual result: -------------- The first line causes 2 retries (3 total attempts) the second causes 0 retries (1 total attempts). ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=55313&edit=1