Bug #50696 [Com]: number_format when passed a 0 as first function argument, returns null

Edit report at https://bugs.php.net/bug.php?id=50696&edit=1 ID: 50696 Comment by: jacob at jacobweber dot com Reported by: endosquid at endosquid dot com Summary: number_format when passed a 0 as first function argument, returns null Status: Wont fix Type: Bug Package: Math related Operating System: Linux 32 bit PHP Version: 5.3.1 Block user comment: N Private report: N New Comment: Fun thread! Anyway, I was wondering if anyone has a complete list of the functions that changed as a result of this zend_parse_parameters() fix. I don't see anything specific in the upgrade instructions: http://www.php.net/manual/en/migration53.incompatible.php Also, will number_format((float) $x) behave under PHP 5.3.x exactly the same way that number_format($x) behaved under PHP 5.2.x? Are there any subtle differences? Thanks. Previous Comments: ------------------------------------------------------------------------ [2010-01-08 23:47:19] bjori@php.net Sir. This issue was recently brought to my attention. On behalf of PHP I would like to apologize. I see that now that you have been treated unfairly. After carefully reviewing this bug report with our board of directors on 4chan, we have come to the conclusion that your "rusty C skills" should be enough to fix the issue. I would therefore like to remind you that rasmus@php.net is http://en.wikipedia.org/wiki/Rasmus_lerdorf Again, I sincerely apologize. We will try to stop fixing bugs in PHP. ------------------------------------------------------------------------ [2010-01-08 23:22:52] endosquid at endosquid dot com Just look in the mirror, pal. You need classes on how to listen to others. ------------------------------------------------------------------------ [2010-01-08 23:20:13] rasmus@php.net Wow, a classic case of how not to treat unpaid volunteers who provide critical pieces of your money-making infrastructure. ------------------------------------------------------------------------ [2010-01-08 23:05:43] endosquid at endosquid dot com I get it. Yours is bigger, you've worked better, you are at the cutting edge of everything, and you have infinite resources to test every new version of every piece of software in your stack. Got it. I'm shamed and have no options. So, you're going to give a cover-all answer to make sure that you don't have to do anything. Ok, I get it. I hope no one ever does this to you, because it makes you lose faith in the product. We will push forwrd with patching the source. It would appear that the 1194th line in math.c is the one that needs changing. returning 0 as opposed to returning nothing? I'll edit and compile. ------------------------------------------------------------------------ [2010-01-08 22:47:04] rasmus@php.net I have worked in such environments. Much bigger ones, in fact. Part of your responsibility in your position is to keep track of your tools and the changes coming down the pipeline. 5.3 was available to you as a release candidate in March of last year, and even earlier directly from our revision control system. Many things have changed and there are many many people out there affected by these changes, we recognize that. That is also why we are not likely to reverse a change like this that others in your situation have now accounted for, tested and deployed in production for many months simply because it is inconvenient for you. ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=50696 -- Edit this bug report at https://bugs.php.net/bug.php?id=50696&edit=1