Bug #39388 [Com]: provide --with-libzip-dir configure option to allow usage of system's libzip

From: Date: Wed, 28 Sep 2011 05:35:26 +0000
Subject: Bug #39388 [Com]: provide --with-libzip-dir configure option to allow usage of system's libzip
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-163936@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=39388&edit=1

 ID:                 39388
 Comment by:         glen at delfi dot ee
 Reported by:        crrodriguez at opensuse dot org
 Summary:            provide --with-libzip-dir configure option to allow
                     usage of system's libzip
 Status:             Bogus
 Type:               Bug
 Package:            Zip Related
 Operating System:   Linux
 PHP Version:        5CVS-2006-11-05 (CVS)
 Assigned To:        pajoye
 Block user comment: N
 Private report:     N

 New Comment:

i updated the patch to really link with system libzip and not to link
with libz (as that it is libzip dependency not zip ext in case of system libzip)

http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/packages/php/system-libzip.patch?
sortby=date

i would reformat the patch indent if there's any interest it getting
applied upstream, it's currently "broken" indent just to get diffs
better to understand (and update with new upstream changes)


Previous Comments:
------------------------------------------------------------------------
[2011-07-20 17:40:51] crrodriguez at opensuse dot org

tcallawa at redhat dot com : Great, patches look OK, will try them asap in openSUSE packages.

------------------------------------------------------------------------
[2011-07-20 15:54:40] tcallawa at redhat dot com

It doesn't look like 0.10 will work with PHP's zip extension out of the tarball, because
it is still missing some necessary features that were never upstreamed (as far as I can tell).
I've worked up a patch against 0.10 that adds the necessary functionality, and sent a copy to
the libzip upstream for consideration. A copy of that patch can be found here:

http://spot.fedorapeople.org/libzip-0.10-php-changes.patch

Then, I reworked ext/zip/config.m4 to enable an option to use libzip (the system copy). That patch
is here:

http://spot.fedorapeople.org/php-5.3.6-libzip.patch

I couldn't figure out a good way to test for overwrite support (the bits that the first patch
add), so the configure tests will pass on a system libzip without the php changes applied, but I
don't think the compile will succeed (it definitely won't work properly).

------------------------------------------------------------------------
[2011-04-06 08:33:48] oeriksson at mandriva dot com

With the recent security flaws related to libzip it's desirable to enable this option.
Isn't the latest http://www.nih.at/libzip/libzip-0.10.tar.bz2
going to work fine now?

------------------------------------------------------------------------
[2006-11-05 19:21:28] pajoye@php.net

There is no need of it. And no, you should *really* not use an external library.

The version bundled have more fixes and features than the released lib. Most of them are already in
the libzip cvs, other not.

------------------------------------------------------------------------
[2006-11-05 03:50:59] crrodriguez at opensuse dot org

Description:
------------
Currently there is no  --with-libzip-dir to easily allow distributions to use independantly packaged
system libraries.

Reproduce code:
---------------
./configure --help | grep zip

Expected result:
----------------
--enable-zip        Include Zip read/write support.
--with-zlib-dir=DIR   zip: Set the path to libz install prefix.
--with-libzip=DIR     zip : path to libzip sources if not using the bundled library.

Actual result:
--------------
--enable-zip        Include Zip read/write support.
--with-zlib-dir=DIR   zip: Set the path to libz install prefix.


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=39388&edit=1


Thread (8 messages)

« previous php.bugs (#163936) next »