Bug #60120 [Asn->Csd]: proc_open hangs with stdin/out with 2048+ bytes
| From: | pajoye@php.net | Date: | Wed, 26 Oct 2011 08:41:57 +0000 |
| Subject: | Bug #60120 [Asn->Csd]: proc_open hangs with stdin/out with 2048+ bytes | ||
| References: | 1 | Groups: | php.bugs |
| Request: | Send a blank email to php-bugs+get-164576@lists.php.net to get a copy of this message | ||
Edit report at https://bugs.php.net/bug.php?id=60120&edit=1
ID: 60120
Updated by: pajoye@php.net
Reported by: pajoye@php.net
Summary: proc_open hangs with stdin/out with 2048+ bytes
-Status: Assigned
+Status: Closed
Type: Bug
Package: Filesystem function related
Operating System: windows
PHP Version: Irrelevant
Assigned To: pajoye
Block user comment: N
Private report: N
New Comment:
This bug has been fixed in SVN.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
For Windows:
http://windows.php.net/snapshots/
Thank you for the report, and for helping us make PHP better.
yes (see the commit tab :), I forgot to close it. Thanks for the headup!
Previous Comments:
------------------------------------------------------------------------
[2011-10-26 06:23:54] fabien at symfony dot com
AFAIK, this bug has been fixed here: http://svn.php.net/viewvc?
view=revision&revision=318366
------------------------------------------------------------------------
[2011-10-24 12:39:53] pajoye@php.net
Automatic comment from SVN on behalf of pajoye
Revision: http://svn.php.net/viewvc/?view=revision&revision=318366
Log: - fixed bug #60120, proc_open's streams may hang with stdin/out/err when the data exceeds
or is equal to 2048 bytes
------------------------------------------------------------------------
[2011-10-24 12:10:03] pajoye@php.net
Description:
------------
The stream used to read data from stdin/out/err hangs if the data passed is
getting larger than 2048, under certain circumstances.
Test script:
---------------
error_reporting(E_ALL);
$cmd = 'php -r "fwrite(STDOUT, $in = file_get_contents(\'php://stdin\'));
fwrite(STDERR, $in);"';
$descriptors = array(array('pipe', 'r'), array('pipe', 'w'),
array('pipe', 'w'));
$stdin = str_repeat('*', 1024 * 16) . '!';
$stdin = str_repeat('*', 2049 );
$options = array_merge(array('suppress_errors' => true, 'binary_pipes' =>
true, 'bypass_shell' => false));
$process = proc_open($cmd, $descriptors, $pipes, getcwd(), array(), $options);
foreach ($pipes as $pipe) {
stream_set_blocking($pipe, false);
}
$writePipes = array($pipes[0]);
$stdinLen = strlen($stdin);
$stdinOffset = 0;
unset($pipes[0]);
while ($pipes || $writePipes) {
$r = $pipes;
$w = $writePipes;
$e = null;
$n = stream_select($r, $w, $e, 60);
if (false === $n) {
break;
} elseif ($n === 0) {
proc_terminate($process);
}
if ($w) {
$written = fwrite($writePipes[0], (binary)substr($stdin, $stdinOffset), 8192);
if (false !== $written) {
$stdinOffset += $written;
}
if ($stdinOffset >= $stdinLen) {
fclose($writePipes[0]);
$writePipes = null;
}
}
foreach ($r as $pipe) {
$type = array_search($pipe, $pipes);
$data = fread($pipe, 8192);
if (false === $data || feof($pipe)) {
fclose($pipe);
unset($pipes[$type]);
}
}
}
------------------------------------------------------------------------
--
Edit this bug report at https://bugs.php.net/bug.php?id=60120&edit=1