Bug #60659 [Opn->Csd]: FPM does not clear auth_user on request accept

Edit report at https://bugs.php.net/bug.php?id=60659&edit=1 ID: 60659 Updated by: fat@php.net Reported by: bonbons at linux-vserver dot org Summary: FPM does not clear auth_user on request accept -Status: Open +Status: Closed Type: Bug Package: FPM related Operating System: Linux PHP Version: 5.3.8 -Assigned To: +Assigned To: fat Block user comment: N Private report: N New Comment: This bug has been fixed in SVN. Snapshots of the sources are packaged every three hours; this change will be in the next snapshot. You can grab the snapshot at http://snaps.php.net/. For Windows: http://windows.php.net/snapshots/ Thank you for the report, and for helping us make PHP better. Thanks you very much for this fix. Previous Comments: ------------------------------------------------------------------------ [2012-01-04 21:19:28] fat@php.net Automatic comment from SVN on behalf of fat Revision: http://svn.php.net/viewvc/?view=revision&revision=321771 Log: - Fixed credits for bug #60659 ------------------------------------------------------------------------ [2012-01-04 21:17:59] fat@php.net Automatic comment from SVN on behalf of fat Revision: http://svn.php.net/viewvc/?view=revision&revision=321770 Log: - Fixed bug #60659 (FPM does not clear auth_user on request accept) ------------------------------------------------------------------------ [2012-01-04 20:14:12] bonbons at linux-vserver dot org Description: ------------ Multiple requests hitting the same FPM worker process will get logged (by php-fpm) with the last authenticated user seen instead of empty when there is no authenticated user for the current request. Attached patch clears auth_user field (and also clears query_string), those two being the only char arrays not seeing initialization in fpm_request_accepting(). Test script: --------------- # configure php-fpm to use only one worker and log access restart php-fpm curl -u user $php_fpm_page_via_nginx curl $php_fpm_page_via_nginx curl $php_fpm_page_via_nginx # All logged access lines will show remote user to be "user" ------------------------------------------------------------------------ -- Edit this bug report at https://bugs.php.net/bug.php?id=60659&edit=1