Bug #60809 [PATCH]: TRAITS - PHPDoc Comment Style Bug

Edit report at https://bugs.php.net/bug.php?id=60809&edit=1 ID: 60809 Patch added by: pierrick@php.net Reported by: micronix at gmx dot net Summary: TRAITS - PHPDoc Comment Style Bug Status: Critical Type: Bug Package: *General Issues Operating System: Windows PHP Version: 5.4.0RC5 Assigned To: pierrick Block user comment: N Private report: N New Comment: The following patch has been added/updated: Patch Name: bug60809.phpt Revision: 1327027197 URL: https://bugs.php.net/patch-display.php?bug=60809&patch=bug60809.phpt&revision=1327027197 Previous Comments: ------------------------------------------------------------------------ [2012-01-20 02:32:52] laruence@php.net ah, you are right, ingore my noise :) ------------------------------------------------------------------------ [2012-01-20 02:28:53] pierrick@php.net I can do it like that yes. I'll just have to declare the variable inside the loop to make sure the doc_comment is reinitialized and NULL if no doc_comment is there. ------------------------------------------------------------------------ [2012-01-20 02:26:32] laruence@php.net pierrick, I suggest doing like: char *doccomment = NULL; if () { doccomment = estrndup(); } thanks :) ------------------------------------------------------------------------ [2012-01-20 02:26:31] laruence@php.net pierrick, I suggest doing like: char *doccomment = NULL; if () { doccomment = estrndup(); } thanks :) ------------------------------------------------------------------------ [2012-01-20 02:21:52] pierrick@php.net Problem is because zend_do_traits_property_binding use zend_declare_property_ex without doing a estrndup of the doc_comment. I attached a patch please Stas or dsp confirm that I can commit it :) ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=60809 -- Edit this bug report at https://bugs.php.net/bug.php?id=60809&edit=1