Req #60871 [Opn->Csd]: Support creating collations in SQLite3 class

From: Date: Sun, 29 Jan 2012 04:01:19 +0000
Subject: Req #60871 [Opn->Csd]: Support creating collations in SQLite3 class
References: 1  Groups: php.bugs 
Request: Send a blank email to php-bugs+get-166913@lists.php.net to get a copy of this message 
Edit report at https://bugs.php.net/bug.php?id=60871&edit=1

 ID:                 60871
 Updated by:         rasmus@php.net
 Reported by:        macdewar at gmail dot com
 Summary:            Support creating collations in SQLite3 class
-Status:             Open
+Status:             Closed
 Type:               Feature/Change Request
 Package:            SQLite related
 Operating System:   GNU/Linux
 PHP Version:        5.3.9
-Assigned To:        
+Assigned To:        rasmus
 Block user comment: N
 Private report:     N

 New Comment:

Patch applied, thanks.


Previous Comments:
------------------------------------------------------------------------
[2012-01-29 03:57:27] rasmus@php.net

Automatic comment from SVN on behalf of rasmus
Revision: http://svn.php.net/viewvc/?view=revision&revision=322913
Log: Good patch from Brad Dewar that adds missing createCollation()
method. Fixes bug #60871 and is related to bug #55226

------------------------------------------------------------------------
[2012-01-29 03:03:17] macdewar at gmail dot com

Added new patch, set status back to open.

------------------------------------------------------------------------
[2012-01-29 02:50:41] macdewar at gmail dot com

Well, that's embarrassing.

There's a new patch with the required fixes, and it has been _VERY_ carefully checked.

(I was doing some last-minute refactoring before submitting; must have sent a diff from midway
through the change, rather than the final version. ...)

------------------------------------------------------------------------
[2012-01-28 02:17:16] rasmus@php.net

This doesn't compile for me. It applied cleanly but I get:

/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c: In function 
‘php_sqlite3_callback_compare’:
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:885:58: warning: 
dereferencing ‘void *’ pointer [enabled by default]
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:885:58: error: 
request for member ‘fci’ in something not a structure or union
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c: In function 
‘zim_sqlite3_createCollation’:
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:1053:62: error: 
‘ud_cmp_func’ undeclared (first use in this function)
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:1053:62: note: each 
undeclared identifier is reported only once for each function it appears in
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:1054:12: error: 
‘php_sqlite3_collation’ has no member named ‘collation_name’
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c: In function 
‘php_sqlite3_object_free_storage’:
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:2055:50: error: 
‘php_sqlite3_collation’ has no member named ‘collation_name’
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:2057:27: error: 
‘php_sqlite3_collation’ has no member named ‘collation_name’
/home/rasmus/php-src/branches/PHP_5_3/ext/sqlite3/sqlite3.c:2058:7: error: 
‘cmp_func’ undeclared (first use in this function)
make: *** [ext/sqlite3/sqlite3.lo] Error 1

I haven't looked into it beyond applying the patch and trying to build.

------------------------------------------------------------------------
[2012-01-24 19:14:37] macdewar at gmail dot com

Test script has a typo.

replace "COLLATE NAT" with "COLLATE NATCMP"

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=60871


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=60871&edit=1

Thread (6 messages)

« previous php.bugs (#166913) next »